Skip to content

Missing 'until' params #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mortharia wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Missing 'until' params #1429

mortharia wants to merge 2 commits into from

Conversation

@mortharia
Copy link

@mortharia mortharia commented Jul 7, 2020 •
edited
Loading

fix #1427

@mortharia mortharia changed the title Add LogContainerCmd until param Missing until params #1427 Jul 7, 2020
@mortharia mortharia changed the title Missing until params #1427 Missing until params Jul 7, 2020
@mortharia mortharia changed the title Missing until params Missing 'until' params Jul 7, 2020
@stale
Copy link

stale bot commented Aug 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this Aug 14, 2020
@mortharia mortharia changed the title Missing 'until' params Missing 'until' params Nov 24, 2020
@bsideup bsideup reopened this Sep 13, 2021
@bsideup
Copy link
Member

bsideup commented Sep 13, 2021

@mortharia sorry for letting it stale. Could you please change the test to not use Thread.sleeps? Thank you!

@stale stale bot removed the resolution/stale label Sep 13, 2021
eddumelendez
eddumelendez reviewed Mar 8, 2023
View reviewed changes
docker-java/src/test/java/com/github/dockerjava/cmd/LogContainerCmdIT.java
assertThat(container.getId(), not(is(emptyString())));

dockerRule.getClient().startContainerCmd(container.getId()).exec();
Thread.sleep(5000);
Copy link
Member

@eddumelendez eddumelendez Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Awaitility instead

@eddumelendez eddumelendez requested a review from a team as a code owner August 19, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eddumelendez eddumelendez eddumelendez left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

resolution/acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing until params

3 participants

@mortharia @bsideup @eddumelendez