cli/registry/client: remove unused types, and deprecate RepoNameForReference#5882
Merged
thaJeztah merged 3 commits intodocker:masterfrom Mar 4, 2025
Merged
cli/registry/client: remove unused types, and deprecate RepoNameForReference#5882thaJeztah merged 3 commits intodocker:masterfrom
thaJeztah merged 3 commits intodocker:masterfrom
Conversation
This type was added in 02719bd, but was never used; git rev-parse --verify HEAD 02719bd git grep 'PutManifestOptions' cli/registry/client/client.go:// PutManifestOptions is the data sent to push a manifest cli/registry/client/client.go:type PutManifestOptions struct { This patch removes it, because it's not used. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This type was added in 02719bd, but was never used outside of the package itself. This patch un-exports it. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This function was added in 02719bd, and used newDefaultRepositoryEndpoint to get repository info for the given image-reference. newDefaultRepositoryEndpoint uses registry.ParseRepositoryInfo under the hood, but the only information used from the result was the Name field, which is set using `reference.TrimNamed(name)`. The possible error returned was based on the domain-name of the image, and only checked for the domain to not start, or end with a hyphen ("-"). This patch removes the use of RepoNameForReference, deprecates it, and inlines the code used by it. There are no known consumers of this function, so we can consider removing it in the first possible release after this (which can be a minor release). Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #5882 +/- ##
==========================================
- Coverage 59.31% 59.27% -0.04%
==========================================
Files 353 353
Lines 29735 29726 -9
==========================================
- Hits 17637 17620 -17
- Misses 11117 11134 +17
+ Partials 981 972 -9 |
vvoland
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli/registry/client: remove unused PutManifestOptions
This type was added in 02719bd, but was
never used;
This patch removes it, because it's not used.
cli/registry/client: un-export ErrHTTPProto
This type was added in 02719bd, but was
never used outside of the package itself. This patch un-exports it.
cli/registry/client: deprecate RepoNameForReference
This function was added in 02719bd, and
used newDefaultRepositoryEndpoint to get repository info for the given
image-reference.
newDefaultRepositoryEndpoint uses registry.ParseRepositoryInfo under the
hood, but the only information used from the result was the Name field,
which is set using
reference.TrimNamed(name). The possible error returnedwas based on the domain-name of the image, and only checked for the domain
to not start, or end with a hyphen ("-").
This patch removes the use of RepoNameForReference, deprecates it, and
inlines the code used by it.
There are no known consumers of this function, so we can consider removing
it in the first possible release after this (which can be a minor release).
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)