feat(v2): tensor column mode #886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsja
force-pushed
the
feat-tensor-column-mode
branch
from
fe10440 to
31d85d8
Compare
samsja
force-pushed
the
feat-tensor-column-mode
branch
from
915406d to
342a726
Compare
JohannesMessner
requested changes
Dec 5, 2022
samsja
force-pushed
the
feat-tensor-column-mode
branch
3 times, most recently
from
63c74c7 to
62671f3
Compare
JohannesMessner
requested changes
Dec 6, 2022
alexcg1
suggested changes
Dec 6, 2022
| **Unstacked mode (default)**: | ||
| In this case a DocumentArray is a list of Documents and each Document owns its data. |
Contributor
There was a problem hiding this comment.
What does it mean to for a Document to "own" data?
Member
Author
There was a problem hiding this comment.
it means that the data is bound to the lifecycle of the Document. If the Document go out of scope the data as well
Contributor
There was a problem hiding this comment.
Would it also be accurate to say the Document stores the data?
Member
Author
There was a problem hiding this comment.
I think here owning the the good term from a computer science point of view
samsja
force-pushed
the
feat-tensor-column-mode
branch
from
78b7968 to
b6770d2
Compare
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Co-authored-by: Johannes Messner <[email protected]> Signed-off-by: samsja <[email protected]> Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Co-authored-by: Alex Cureton-Griffiths <[email protected]> Signed-off-by: samsja <[email protected]> Signed-off-by: Sami Jaghouar <[email protected]>
Co-authored-by: Alex Cureton-Griffiths <[email protected]> Signed-off-by: samsja <[email protected]> Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
samsja
force-pushed
the
feat-tensor-column-mode
branch
from
b6770d2 to
0b3f538
Compare
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
alexcg1
suggested changes
Dec 6, 2022
Contributor
alexcg1
left a comment
alexcg1
left a comment
There was a problem hiding this comment.
I missed a few things last time round 😅
| **Unstacked mode (default)**: | ||
| In this case a DocumentArray is a list of Documents and each Document owns its data. |
Contributor
There was a problem hiding this comment.
Would it also be accurate to say the Document stores the data?
Signed-off-by: Sami Jaghouar <[email protected]>
Co-authored-by: Alex Cureton-Griffiths <[email protected]> Signed-off-by: samsja <[email protected]>
Co-authored-by: Alex Cureton-Griffiths <[email protected]> Signed-off-by: samsja <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
Signed-off-by: Sami Jaghouar <[email protected]>
JohannesMessner
approved these changes
Dec 6, 2022
|
📝 Docs are deployed on https://ft-feat-tensor-column-mode--jina-docs.netlify.app 🎉 |
47 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
introducing the stacked mode for faster computation and saving memory when dealing with tensor when needed:
We expose as well a context manager