feat: support list of strings for Weaviate #1852
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1852 +/- ##
==========================================
- Coverage 85.06% 82.71% -2.35%
==========================================
Files 136 136
Lines 9260 9270 +10
==========================================
- Hits 7877 7668 -209
- Misses 1383 1602 +219
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hsm207
reviewed
Feb 8, 2024
docarray/index/backends/weaviate.py
Outdated
Comment on lines
727
to
728
| int: 'number[]', | ||
| float: 'number[]', |
Contributor
There was a problem hiding this comment.
a list of int in python should be mapped to 'int[]' in weaviate, since 'number[]' is for float64
hsm207
suggested changes
Feb 8, 2024
Contributor
hsm207
left a comment
hsm207
left a comment
There was a problem hiding this comment.
thanks for implementing this.
i just have 1 comment.
JoanFM
force-pushed
the
weaviate-support-list-str
branch
from
416a12d to
af219af
Compare
hsm207
approved these changes
Feb 8, 2024
|
📝 Docs are deployed on https://ft-weaviate-support-list-str--jina-docs.netlify.app 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.