Skip to content

Conversation

@ai-naymul
Copy link
Contributor

@samsja ,
Could you please check the PR and let me know if is there any issue :)

@codecov
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff00b60) 83.61% compared to head (9369a9e) 85.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1837      +/-   ##
==========================================
+ Coverage   83.61%   85.07%   +1.45%     
==========================================
  Files         136      136              
  Lines        9255     9255              
==========================================
+ Hits         7739     7874     +135     
+ Misses       1516     1381     -135     
Flag Coverage Δ
docarray 85.07% <ø> (+1.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice !

@samsja
Copy link
Member

samsja commented Dec 21, 2023

I will let @JoanFM do the merge. For more context see discussion here: #1833 (comment)

@JoanFM JoanFM merged commit 8de3e17 into docarray:main Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants