fix: skip annotations if not in __fields__ #1779
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @NarekA here we need you to signoff ur commits. Could you do this please? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1779 +/- ##
==========================================
- Coverage 84.99% 81.98% -3.02%
==========================================
Files 134 134
Lines 8845 8847 +2
==========================================
- Hits 7518 7253 -265
- Misses 1327 1594 +267
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
NarekA
force-pushed
the
fix-skip-annotations-not-in-field-narek
branch
3 times, most recently
from
4c97fe4 to
3b105bd
Compare
Signed-off-by: Nareka <[email protected]>
NarekA
force-pushed
the
fix-skip-annotations-not-in-field-narek
branch
from
3b105bd to
9c84e54
Compare
Author
|
@JoanFM I can't figure out signing github commits, why don't you just merge your branch. I'm giving up on this one. |
Member
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #1777
@JoanFM