Skip to content

feat(v2): add tensorflow embedding, audio, video #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anna-charlotte merged 91 commits into from
Feb 9, 2023
Merged

feat(v2): add tensorflow embedding, audio, video #1098

anna-charlotte merged 91 commits into from
Feb 9, 2023

Conversation

@anna-charlotte
Copy link
Contributor

@anna-charlotte anna-charlotte commented Feb 8, 2023 •
edited
Loading

Add further tensorflow support:

  • TensorFlowEmbedding
  • VideoTensorFlowTensor
  • AudioTensorFlowTensor
  • ImageTensorFlowTensor
  • Tests
  • check and update documentation, if required. See guide

anna-charlotte added 30 commits February 7, 2023 10:36
feat: add tensorflow tensor
ba1a4b6 
Signed-off-by: anna-charlotte <[email protected]>
feat: wip add tf comp backend
978dfe4 
Signed-off-by: anna-charlotte <[email protected]>
fix: comp backend working of TensorFlowTensor, not tf tensor
712c950 
Signed-off-by: anna-charlotte <[email protected]>
test: remove redundant print statements
fd88185 
Signed-off-by: anna-charlotte <[email protected]>
feat: add comp backend retrieval
17fe3d5 
Signed-off-by: anna-charlotte <[email protected]>
fix: extract methods that overlap for np and tf backend
b0fd980 
Signed-off-by: anna-charlotte <[email protected]>
fix: revert poetry lock change
c2e6ab0 
Signed-off-by: anna-charlotte <[email protected]>
fix: introduce norm callables to transform tftensor
cf6a0ef 
Signed-off-by: anna-charlotte <[email protected]>
docs: clean up
194ab9f 
Signed-off-by: anna-charlotte <[email protected]>
fix: retrieval and add docstring
6a2ecf1 
Signed-off-by: anna-charlotte <[email protected]>
fix: add cosine sim for tf backend matrics
056db70 
Signed-off-by: anna-charlotte <[email protected]>
fix: euclidean dist
6c35902 
Signed-off-by: anna-charlotte <[email protected]>
fix: add typevar to register proto
2abe113 
Signed-off-by: anna-charlotte <[email protected]>
fix: clean up
beb340e 
Signed-off-by: anna-charlotte <[email protected]>
fix: add tft to inits
1817c44 
Signed-off-by: anna-charlotte <[email protected]>
test: add tests for tensorflow tensor
a74daac 
Signed-off-by: anna-charlotte <[email protected]>
fix: mypy checks
ab7d153 
Signed-off-by: anna-charlotte <[email protected]>
fix: docarray from native
72744ad 
Signed-off-by: anna-charlotte <[email protected]>
docs: add documentatino and clean up
dfdff10 
Signed-off-by: anna-charlotte <[email protected]>
fix: clean up
28a7291 
Signed-off-by: anna-charlotte <[email protected]>
fix: clean up
418ee37 
Signed-off-by: anna-charlotte <[email protected]>
fix: stacked array with tf tensor
217c870 
Signed-off-by: anna-charlotte <[email protected]>
fix: stack with tftensor
fd7a8e5 
Signed-off-by: anna-charlotte <[email protected]>
test: fix get item test
26150b6 
Signed-off-by: anna-charlotte <[email protected]>
fix: access by slice for tftensor
567b56a 
Signed-off-by: anna-charlotte <[email protected]>
fix: add proto for tf
665f408 
Signed-off-by: anna-charlotte <[email protected]>
test: introduce pytest tensorflow marker
68bdd77 
Signed-off-by: anna-charlotte <[email protected]>
fix: typo in ci.yml
fcd5b74 
Signed-off-by: anna-charlotte <[email protected]>
fix: try tf import
1e8e240 
Signed-off-by: anna-charlotte <[email protected]>
fix: mypy
a5988ab 
Signed-off-by: anna-charlotte <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

chore: update lock file
6a92e22 
Signed-off-by: anna-charlotte <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@anna-charlotte anna-charlotte changed the title feat(v2): Add tensorflow embedding, audio, video feat(v2): add tensorflow embedding, audio, video Feb 8, 2023
anna-charlotte added 2 commits February 8, 2023 16:13
test: fix tf test and clean up
37d9355 
Signed-off-by: anna-charlotte <[email protected]>
test: fix video test tf
7ef37e4 
Signed-off-by: anna-charlotte <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@anna-charlotte anna-charlotte marked this pull request as ready for review February 8, 2023 16:15
@anna-charlotte anna-charlotte requested review from JohannesMessner and samsja and removed request for samsja February 8, 2023 16:30
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@anna-charlotte anna-charlotte linked an issue Feb 8, 2023 that may be closed by this pull request
v2: Add Tensforflow support #1057
Closed
3 tasks
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

📝 Docs are deployed on https://ft-feat-tf-embedding--jina-docs.netlify.app 🎉

@anna-charlotte anna-charlotte merged commit 8bd0443 into feat-rewrite-v2 Feb 9, 2023
@anna-charlotte anna-charlotte deleted the feat-tf-embedding branch February 9, 2023 09:00
@anna-charlotte anna-charlotte mentioned this pull request Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsja samsja samsja approved these changes

@JohannesMessner JohannesMessner Awaiting requested review from JohannesMessner

Assignees

No one assigned

Labels

area/core area/testing area/typing component/array size/xl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v2: Add Tensforflow support

3 participants

@anna-charlotte @samsja