-
Notifications
You must be signed in to change notification settings - Fork 234
feat: add filter capability to DocumentArray #1051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f76d828 to
71aee07
Compare
#1026) * test: add tensor ops tests Signed-off-by: Jackmin801 <[email protected]> * feat: instances of parametrized types are not parametrized anymore Signed-off-by: Jackmin801 <[email protected]> * test: fix test that have been changed by this feature Signed-off-by: Jackmin801 <[email protected]> * refactor: change class name and add comments Signed-off-by: Jackmin801 <[email protected]> * test: add tests to make sure isinstance does not do coercion Signed-off-by: Jackmin801 <[email protected]> * fix: parametrized isinstance check should not perform coercion Signed-off-by: Jackmin801 <[email protected]> * test: add more tests to parametrized class name tests Signed-off-by: Jackmin801 <[email protected]> * style: small black fix Signed-off-by: Jackmin801 <[email protected]> Signed-off-by: Jackmin801 <[email protected]> Signed-off-by: Joan Fontanals Martinez <[email protected]>
* feat: add rich display for doc and da Signed-off-by: anna-charlotte <[email protected]> * fix: wip plot Signed-off-by: anna-charlotte <[email protected]> * fix: wip plot Signed-off-by: anna-charlotte <[email protected]> * fix: wip plot Signed-off-by: anna-charlotte <[email protected]> * feat: add math package and minmax normalize Signed-off-by: anna-charlotte <[email protected]> * fix: summary for document Signed-off-by: anna-charlotte <[email protected]> * chore: update poetry lock after rebase Signed-off-by: anna-charlotte <[email protected]> * fix: move all from plotmixin to base document Signed-off-by: anna-charlotte <[email protected]> * feat: add docs schema summary Signed-off-by: anna-charlotte <[email protected]> * feat: add document array summary Signed-off-by: anna-charlotte <[email protected]> * fix: display doc within doc Signed-off-by: anna-charlotte <[email protected]> * fix: in notebook print docs summary Signed-off-by: anna-charlotte <[email protected]> * fix: move summary from da to abstract da Signed-off-by: anna-charlotte <[email protected]> * fix: get schema for doc Signed-off-by: anna-charlotte <[email protected]> * fix: wip doc summary Signed-off-by: anna-charlotte <[email protected]> * fix: wip clean up Signed-off-by: anna-charlotte <[email protected]> * test: add test for da pretty print Signed-off-by: anna-charlotte <[email protected]> * docs: update note Signed-off-by: anna-charlotte <[email protected]> * docs: add some documentation Signed-off-by: anna-charlotte <[email protected]> * fix: apply samis suggestion Signed-off-by: anna-charlotte <[email protected]> * fix: mypy checks Signed-off-by: anna-charlotte <[email protected]> * fix: move to plot mixin Signed-off-by: anna-charlotte <[email protected]> * fix: remove redundant line Signed-off-by: anna-charlotte <[email protected]> * fix: remove comments Signed-off-by: anna-charlotte <[email protected]> * feat: add schema highlighter Signed-off-by: anna-charlotte <[email protected]> * fix: add plotmixin to mixin init Signed-off-by: anna-charlotte <[email protected]> * fix: adjust da summary Signed-off-by: anna-charlotte <[email protected]> * fix: move minmaxnormalize to comp backend Signed-off-by: anna-charlotte <[email protected]> * fix: remove redundant lines Signed-off-by: anna-charlotte <[email protected]> * fix: add squeeze and detach to comp backend Signed-off-by: anna-charlotte <[email protected]> * fix: apply suggestion from code review Signed-off-by: anna-charlotte <[email protected]> * refactor: rename iterable attrs Signed-off-by: anna-charlotte <[email protected]> * fix: clean up Signed-off-by: anna-charlotte <[email protected]> * fix: import Signed-off-by: anna-charlotte <[email protected]> * fix: iterate over fields instead of annotations Signed-off-by: anna-charlotte <[email protected]> * fix: remove math package since moved to comp backends Signed-off-by: anna-charlotte <[email protected]> * refactor: use single quotes Signed-off-by: anna-charlotte <[email protected]> * fix: apply suggestions from code review Signed-off-by: anna-charlotte <[email protected]> * fix: extract summary to doc summary class Signed-off-by: anna-charlotte <[email protected]> * fix: add pretty print for base document Signed-off-by: anna-charlotte <[email protected]> * fix: use rich capture instead of string io Signed-off-by: anna-charlotte <[email protected]> * fix: add colors for optional and union and use only single quotes Signed-off-by: anna-charlotte <[email protected]> * fix: extract display classes to display package Signed-off-by: anna-charlotte <[email protected]> * fix: make da not optional in da summary Signed-off-by: anna-charlotte <[email protected]> * fix: set _console instead of initializing new one everytime in __str__ Signed-off-by: anna-charlotte <[email protected]> * fix: put console at module level Signed-off-by: anna-charlotte <[email protected]> Signed-off-by: anna-charlotte <[email protected]> Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
* feat: add python 3.7 support Signed-off-by: samsja <[email protected]> * feat: remove get args Signed-off-by: samsja <[email protected]> * fix: fix Signed-off-by: samsja <[email protected]> * fix: fix Signed-off-by: samsja <[email protected]> * chore(ci): bump ci Signed-off-by: samsja <[email protected]> Signed-off-by: samsja <[email protected]> Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
JohannesMessner
requested changes
Jan 27, 2023
Signed-off-by: Joan Fontanals Martinez <[email protected]>
samsja
reviewed
Jan 27, 2023
samsja
reviewed
Jan 27, 2023
samsja
reviewed
Jan 27, 2023
samsja
reviewed
Jan 27, 2023
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
JohannesMessner
approved these changes
Jan 27, 2023
|
📝 Docs are deployed on https://ft-v2-filter--jina-docs.netlify.app 🎉 |
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
Add filtering capability with the same QueryLanguage as in v1 docarray.
TODO:
operatorsin every Document Type