Issue 295, (alternate) addresses bug with TSIG verification of large responses#297
Closed
frankarinnet wants to merge 1 commit intodnsjava:masterfrom
arineng:master_issue295_alt_tsig_fix
Closed
Issue 295, (alternate) addresses bug with TSIG verification of large responses#297frankarinnet wants to merge 1 commit intodnsjava:masterfrom arineng:master_issue295_alt_tsig_fix
frankarinnet wants to merge 1 commit intodnsjava:masterfrom
arineng:master_issue295_alt_tsig_fix
Conversation
…lternate approach).
|
SonarCloud Quality Gate failed.
|
ibauersachs
added a commit
that referenced
this pull request
Oct 29, 2023
Closes #295 Closes #297 Closes #298 Closes #299 Co-authored-by: Frank Hill <[email protected]> Co-authored-by: Nick Guichon <[email protected]>
Contributor
Author
ibauersachs
added a commit
that referenced
this pull request
Nov 4, 2023
* Fix handling of multi-message TSIG responses Closes #295 Closes #297 Closes #298 Closes #299 Co-authored-by: Frank Hill <[email protected]> Co-authored-by: Nick Guichon <[email protected]>
ibauersachs
added a commit
that referenced
this pull request
Nov 4, 2023
* Fix handling of multi-message TSIG responses Closes #295 Closes #297 Closes #298 Closes #299 Closes #301 Co-authored-by: Frank Hill <[email protected]> Co-authored-by: Nick Guichon <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternate approach to fixing the large responses TSIG bug (#295) -- really only added for comparison purposes.
Like the other pull request (#296), do not accept without understanding and making some decisions about thread safety.