Skip to content

TCPClient: Fix recv timeout to properly use nanoseconds (#218)#219

Closed
nguydavi wants to merge 1 commit intodnsjava:masterfrom
nguydavi:patch-1
Closed

TCPClient: Fix recv timeout to properly use nanoseconds (#218)#219
nguydavi wants to merge 1 commit intodnsjava:masterfrom
nguydavi:patch-1

Conversation

@nguydavi
Copy link
Copy Markdown

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 23, 2021

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.17%. Comparing base (700856f) to head (24a2933).
⚠️ Report is 206 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/org/xbill/DNS/TCPClient.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
- Coverage     57.21%   57.17%   -0.04%     
+ Complexity     2089     2088       -1     
============================================
  Files           163      163              
  Lines         10908    10908              
  Branches       1573     1573              
============================================
- Hits           6241     6237       -4     
- Misses         4250     4252       +2     
- Partials        417      419       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ibauersachs ibauersachs linked an issue Sep 23, 2021 that may be closed by this pull request
@ibauersachs
Copy link
Copy Markdown
Member

Thanks!
Actually, instead of just replace millis with nanos, the class should store the timeout value instead of endTime to avoid the numeric overflow mentioned in the Javadoc of nanoTime(). Would you mind refactoring TCPClient like this?
Also, 3.5 (current master) will take a while before there's a release. You might want to target the 3.4.x branch instead.

@ibauersachs ibauersachs added this to the v3.5 milestone Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TCPClient incorrect receive timeout

3 participants