Conversation
Deploying eufemia with
|
| Latest commit: |
470d504
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://56e548ce.eufemia-e25.pages.dev |
| Branch Preview URL: | https://break-section.eufemia-e25.pages.dev |
commit: |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| &--spacing-x-small { | ||
| padding-top: var(--spacing-x-small); | ||
| } | ||
| &--spacing-small { | ||
| padding-top: var(--spacing-small); | ||
| } | ||
| &--spacing-medium { | ||
| padding-top: var(--spacing-medium); | ||
| } | ||
| &--spacing-large { | ||
| padding-top: var(--spacing-large); | ||
| } | ||
| &--spacing-x-large { | ||
| padding-top: var(--spacing-x-large); | ||
| } | ||
| &--spacing-xx-large { | ||
| padding-top: var(--spacing-xx-large); | ||
| } |
There was a problem hiding this comment.
I've added this or sort of moved these here from dnb-section--spacing.
As far as I see these spacing classes is still needed for the content_spacing and tabs_spacing properties support.
So instead of using the dnb-section--spacing class for this, I've added classes to tabs like dnb-tabs--spacing instead
| top | ||
| bottom | ||
| style_type="white" | ||
| > |
There was a problem hiding this comment.
The following adjustments causes changes to the Tabs screenshot tests.
I feel that I've done the correct migration, just changing spacing to be innerSpace={{ top: true, bottom: true }}, but together with top and bottom property, it seems like it results in visual changes...
See adjusted screenshot tests for tabs, I do believe they are all based on this example/demo
| <Wrapper> | ||
| <ComponentBox data-visual-test="anchor-in-section"> | ||
| <Section spacing> | ||
| <Section innerSpace={{ top: true, bottom: true }}> |
There was a problem hiding this comment.
Migration-wise, I feel like I've done the correct migration, by replacing spacing with innerSpace={{ top: true, bottom: true }}, but some how this change also have led to updated screenshot test: 470d504
tujoworker
force-pushed
the
v11
branch
6 times, most recently
from
4f31265 to
bd2083c
Compare
tujoworker
force-pushed
the
v11
branch
2 times, most recently
from
9682439 to
338304c
Compare
|
Branch Preview URL (stable): Deployment URL (unique): |
1 participant
No description provided.