Skip to content

break(DatePicker)!: replace alignPicker with alignCalendar#6523

Open
langz wants to merge 1 commit intov11from
chore/align-picker-to-align-calendar
Open

break(DatePicker)!: replace alignPicker with alignCalendar#6523
langz wants to merge 1 commit intov11from
chore/align-picker-to-align-calendar

Conversation

@langz
Copy link
Contributor

@langz langz commented Jan 29, 2026

Not 100% sure about this one. But today on main, the prop docs says:

Use right to change the preferred calendar alignment direction. Defaults to left. If the DatePicker is close to the edge of the screen, the alignment of the calendar will change automatically to fit in the viewport.

@langz langz requested review from joakbjerk and tujoworker and removed request for joakbjerk January 29, 2026 20:30
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 29, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@cloudflare-workers-and-pages
Copy link

Deploying eufemia with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d14af2
Status: ✅  Deploy successful!
Preview URL: https://7ede80dd.eufemia-e25.pages.dev
Branch Preview URL: https://chore-align-picker-to-align.eufemia-e25.pages.dev

View logs

@tujoworker tujoworker force-pushed the v11 branch 3 times, most recently from 418358f to 511bb30 Compare February 11, 2026 06:43
@tujoworker tujoworker force-pushed the v11 branch 4 times, most recently from 4f31265 to bd2083c Compare February 17, 2026 09:39
@tujoworker tujoworker force-pushed the v11 branch 2 times, most recently from 9682439 to 338304c Compare February 27, 2026 11:05
@tujoworker
Copy link
Member

Needs a rebase.

@langz
Copy link
Contributor Author

langz commented Mar 6, 2026

Needs a rebase.

Sure, I can do so if we want to look into this, and potentially include it in v11 👍
No point in spending time to rebase this if it's nothing we want or need, and then rebasing again and again and again.
If I would've rebased this everytime it had conflicts during the 2 months the PR's been open, I'd spend all my time rebasing for no value 😄

Rebased now, let's hope we'll pick this up before we'll have to rebase again 😅 🙏

@langz langz force-pushed the chore/align-picker-to-align-calendar branch from 0d14af2 to 6f8896f Compare March 6, 2026 18:20
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 6, 2026

commit: 6f8896f

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Branch Preview URL (stable):
https://chore-align-picker-to-align.eufemia-e25.pages.dev

https://chore-align-picker-to-align.eufemia-e25.pages.dev

Deployment URL (unique):
https://44f912ab.eufemia-e25.pages.dev

https://44f912ab.eufemia-e25.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants