Optimize removal of multiple tree nodes - #525
Open
SychicBoy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue(s) this pull request covers:
Fixes #91
Problem
Deleting a large number of selected tree nodes caused significant slowdowns because each individual removal triggered intermediate selection updates and related tree view processing.
This affected deleting large sets of nodes such as types, methods, fields, properties, events, and other members.
Solution
Added a bulk node removal operation to the tree view and updated the assembly editor deletion workflow to use it.
The new removal path calculates the final selection state once before removing the nodes, avoiding repeated intermediate selection updates while preserving existing node removal notifications, selection behavior, and restore/undo functionality.
Changes made:
ITreeView.TreeViewImpl.DeletableNodesto use the new removal path.Tested by deleting large selections containing:
The deletion now completes without noticeable delay, and selection behavior remains correct after removal.