Merged
Conversation
1. Stringify value, hertz and code variables in Transaction.
2. Added variable params in Transaction and Sdk.
3. Removed test variables such as TEST_CODE and hard-coded values in Sdk.java.
4. Removed hard-coded port number 1975 and instead took it from contact.getEndpoint().getPort().
5. Fixes to Utils.toHexString.
6. Fixed Utils.toAddressFromPublicKey, it was resulting into index out of bound exception.
7. Changed DatatypeConverter.parseHexBinary(method) to method.getBytes() since method will be a normal string, not hex string.
8. In class Node, changed endpoint to httpEndpoint, otherwise it wasn't deserializing delegates' host and port. Also changed variable name from contact to node in Sdk.
9. Fixed hash generation code in Transaction. Instead of Utils.longToBytes(value), value.getBytes() is used. For example, value of zero is stringified as "0" and it seems for hash generation, the blockchain expects us to use it as byte[]{0x30} (note that 0x30 is ASCII for zero) instead of something else.
10. Some more fixes to resolve compilation errors.
Stringify api - Java SDK is working again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.