Closed
Conversation
Member
|
Thanks @devansh2605, can you please fix the linting, and then we can proceed to a proper review. |
james-d-mitchell
added
the
waiting for creator input
fingolfin
reviewed
Apr 10, 2025
| return func(a, b, c, d, e, f); | ||
| end; | ||
| else | ||
| Error("Unsupported args: ", args); |
Member
There was a problem hiding this comment.
You could just do:
newMethod := function(args...)
Warning(warningMsg);
return CallFuncList(fun, args);
end;
Member
There was a problem hiding this comment.
Ah this doesn't work, hmmm
Contributor
Author
There was a problem hiding this comment.
@james-d-mitchell sir, should I update this to your suggestion or try an alternative route? Or is the current implementation correct?
Contributor
Author
|
@james-d-mitchell I have fixed the linting as well, pls let me know if any other modifications are required. |
Collaborator
|
I've had a look at this – looks like you've put some work in, but at the moment there are quite a few syntax errors and it's not loading up. Why don't we shelve this for now while you work on other issues? I'll leave the issue open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#735