[rewrite] add `CodeCleanup` #2812

Pankraz76 · 2026-01-10T15:46:58Z

[rewrite] add `CodeCleanup`

https://docs.openrewrite.org/recipes/staticanalysis/codecleanup

There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json
There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json
There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json
All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck
Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by:
    org.openrewrite.staticanalysis.HideUtilityClassConstructor
Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by:
    org.openrewrite.staticanalysis.HideUtilityClassConstructor
Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by:
    org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators
Please review and commit the results.
Estimate time saved: 15m

Pankraz76 · 2026-01-10T16:23:40Z

.github/workflows/ci.yml

      - name: Rewrite ♻️
-        run: ./gradlew rewriteDryRun
-      - name: assemble testClasses
+        run: ./gradlew clean rewriteDryRun


try with clean to avoid regression like seen in: @Goooler

https://github.com/diffplug/spotless/pull/2810/changes#r2678793764

Signed-off-by: Vincent Potucek <[email protected]> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```

Pankraz76 · 2026-01-10T20:20:22Z

.github/workflows/ci.yml

      - name: build (everything-but-maven)
        if: matrix.kind == 'gradle'
-        run: ./gradlew build -x spotlessCheck -x rewriteDryRun -PSPOTLESS_EXCLUDE_MAVEN=true
+        run: ./gradlew clean build -PSPOTLESS_EXCLUDE_MAVEN=true


test locally and partially on CI working assuming flaky build:

Pankraz76 · 2026-01-10T20:21:30Z

.github/workflows/ci.yml

        uses: gradle/actions/setup-gradle@v5
      - name: build (maven-only)
        if: matrix.kind == 'maven'
-        run: ./gradlew :plugin-maven:build -x spotlessCheck -x rewriteDryRun


rewriteDryRun

we only call this on demand.

spotlessCheck

we do not reach here if not complain, could double check here or is this flaky as well, therefore excluded ?

Signed-off-by: Vincent Potucek <[email protected]> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```

Pankraz76 · 2026-01-10T20:47:57Z

.github/workflows/ci.yml

      - name: Rewrite ♻️
-        run: ./gradlew rewriteDryRun
-      - name: assemble testClasses
-        run: ./gradlew assemble testClasses


is came into live as one job:

as its one dedicated goal why not run it also in dedicated job?

Signed-off-by: Vincent Potucek <[email protected]> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```

Pankraz76 · 2026-01-10T21:28:36Z

IO:

Task :testlib:spotbugsMain

Task :lib-extra:test
com.diffplug.spotless.extra.cpp.EclipseCdtFormatterStepTest > formatWithVersion(String) [2] "11.6" FAILED (5s)

com.diffplug.spotless.ThrowingEx$WrappedAsRuntimeException: java.io.IOException: Failed to load eclipse cdt formatter: java.lang.IllegalStateException: P2 operation already in progress, close other clients or delete stale lockfile at /home/runner/.m2/repository/dev/equo/p2-data/metadata/.lock
at app//com.diffplug.spotless.extra.cpp.EclipseCdtFormatterStepTest.formatWithVersion(EclipseCdtFormatterStepTest.java:34)
Caused by: java.io.IOException: Failed to load eclipse cdt formatter: java.lang.IllegalStateException: P2 operation already in progress, close other clients or delete stale lockfile at /home/runner/.m2/repository/dev/equo/p2-data/metadata/.lock
at com.diffplug.spotless.extra.cpp.EclipseCdtFormatterStepTest.formatWithVersion(EclipseCdtFormatterStepTest.java:34)
Caused by: java.lang.IllegalStateException: P2 operation already in progress, close other clients or delete stale lockfile at /home/runner/.m2/repository/dev/equo/p2-data/metadata/.lock
at com.diffplug.spotless.extra.cpp.EclipseCdtFormatterStepTest.formatWithVersion(EclipseCdtFormatterStepTest.java:34)

Signed-off-by: Vincent Potucek <[email protected]> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```

Goooler · 2026-01-11T02:49:56Z

Don't spam. I'm not sure why you introduced OpenRewrite.

You really shouldn't use the 'clean' everywhere.

Pankraz76 force-pushed the CodeCleanup branch 3 times, most recently from ee7d200 to f87a9c3 Compare January 10, 2026 16:19

Pankraz76 mentioned this pull request Jan 10, 2026

[rewrite] apply JavaLangAPIs #2804 #2810

Merged

Pankraz76 force-pushed the CodeCleanup branch from f87a9c3 to 44a77a5 Compare January 10, 2026 16:22

Pankraz76 commented Jan 10, 2026

View reviewed changes

Pankraz76 force-pushed the CodeCleanup branch 3 times, most recently from 7ab4e8c to 9032a0a Compare January 10, 2026 19:01

Pankraz76 marked this pull request as ready for review January 10, 2026 19:07

Pankraz76 force-pushed the CodeCleanup branch 4 times, most recently from 8b5f574 to 2f39be6 Compare January 10, 2026 19:31

Pankraz76 force-pushed the CodeCleanup branch from 2f39be6 to c131cac Compare January 10, 2026 19:31

Pankraz76 commented Jan 10, 2026

View reviewed changes

Vincent Potucek added 5 commits January 10, 2026 21:28

Pankraz76 marked this pull request as draft January 10, 2026 20:37

Vincent Potucek added 4 commits January 10, 2026 21:40

Pankraz76 commented Jan 10, 2026

View reviewed changes

Vincent Potucek added 7 commits January 10, 2026 21:56

Vincent Potucek added 6 commits January 10, 2026 22:34

Goooler closed this Jan 11, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[rewrite] add `CodeCleanup` #2812

[rewrite] add `CodeCleanup` #2812

Pankraz76 commented Jan 10, 2026

Uh oh!

Pankraz76 Jan 10, 2026 •

edited

Loading

Uh oh!

Pankraz76 Jan 10, 2026

Uh oh!

Pankraz76 Jan 10, 2026

Uh oh!

Pankraz76 Jan 10, 2026

Uh oh!

Pankraz76 commented Jan 10, 2026

Uh oh!

Goooler commented Jan 11, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[rewrite] add CodeCleanup #2812

[rewrite] add CodeCleanup #2812

Conversation

Pankraz76 commented Jan 10, 2026