Skip to content

Commit 5970352

Browse files
author
Les Vogel
committed
clean up
1. remove some stuff 2. -B batch —fail-at-end -q quiet
1 parent 83e76f2 commit 5970352

2 files changed

Lines changed: 4 additions & 49 deletions

File tree

.kokoro/system_tests.sh

Lines changed: 3 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -59,30 +59,7 @@ gcloud config list
5959

6060
echo "******** build everything ********"
6161
cd github/getting-started-java
62-
mvn clean verify --fail-at-end -q | grep -E -v "(^\[INFO\] Download|^\[INFO\].*skipping)"
63-
64-
# (
65-
# # Stop echoing commands, so we don't leak secret env vars
66-
# # -Pselenium | \ # LV3 20170616 turn off selenium for now.
67-
# set +x
68-
# mvn --batch-mode clean verify \
69-
# -Dbookshelf.clientID="${OAUTH2_CLIENT_ID}" \
70-
# -Dbookshelf.clientSecret="${OAUTH2_CLIENT_SECRET}" \
71-
# -Dbookshelf.bucket="${GCS_BUCKET envvar is unset}" \
72-
# | \
73-
# grep -E -v "(^\[INFO\] Download|^\[INFO\].*skipping)"
74-
# )
75-
#
76-
# Test running samples on localhost.
77-
# git clone https://github.com/GoogleCloudPlatform/java-repo-tools.git
78-
# ./java-repo-tools/scripts/test-localhost.sh jetty helloworld-jsp -- -DskipTests=true
79-
# ./java-repo-tools/scripts/test-localhost.sh jetty helloworld-servlet -- -DskipTests=true
80-
# ./java-repo-tools/scripts/test-localhost.sh jetty helloworld-compat -- -DskipTests=true
81-
# ./java-repo-tools/scripts/test-localhost.sh spring-boot helloworld-springboot -- -DskipTests=true
82-
83-
# Check that all shell scripts in this repo (including this one) pass the
84-
# Shell Check linter.
85-
# shellcheck ./**/*.sh
62+
mvn -B --fail-at-end -q clean verify | grep -E -v "(^\[INFO\] Download|^\[INFO\].*skipping)"
8663

8764
echo "******** Deploy to QA cluster ********"
8865
cd appengine-standard-java8
@@ -96,27 +73,5 @@ gcloud auth activate-service-account\
9673

9774
./deployAll.sh
9875

99-
## Find all jenkins.sh's and run them.
100-
# find . -mindepth 2 -maxdepth 5 -name jenkins.sh -type f | while read -r path; do
101-
# dir="${path%/jenkins.sh}"
102-
# Need different app versions because flex can't deploy over an existing
103-
# version. Use just the first letter of each subdir in version name
104-
# export GOOGLE_VERSION_ID
105-
# shellcheck disable=SC2001
106-
# GOOGLE_VERSION_ID="jenkins-$(echo "${dir#./}" | sed 's#\([a-z]\)[^/]*/#\1-#g')"
107-
#
108-
# trap 'handle_error "${GOOGLE_VERSION_ID}" "${ERROR_OUTPUT_DIR}"' ERR
109-
# (
110-
# If there's an error, clean up
111-
#
112-
# pushd "${dir}"
113-
# /bin/bash ./jenkins.sh
114-
#
115-
# Clean up the app version
116-
# cleanup
117-
# )
118-
# Clear the trap
119-
# trap - ERR
120-
# done
121-
122-
wait
76+
echo "******** DONE ********"
77+

appengine-standard-java8/deployAll.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ for app in "helloworld" "kotlin-appengine-standard" \
2525
"springboot-appengine-standard" "kotlin-spark-appengine-standard" \
2626
"sparkjava-appengine-standard"
2727
do
28-
(cd "${app}"; mvn appengine:deploy -Dapp.deploy.version="${app}" \
28+
(cd "${app}"; mvn -B --fail-at-end -q appengine:deploy -Dapp.deploy.version="${app}" \
2929
-Dapp.deploy.project="${GOOGLE_CLOUD_PROJECT}" -DskipTests=true)
3030
done
3131

0 commit comments

Comments
 (0)