Skip to content

fix(#111): address review follow-ups from PR #112 #119

@devallibus

Description

@devallibus

Context

PR #112 (consolidate overlapping shiplog workflow PRs) was merged with three follow-up items identified during independent review. These are gaps in new functionality introduced by the consolidation, not regressions.

Tasks

  • T1: Add triage fields to brainstorm.md issue envelope [tier-3]
    SKILL.md's Triage Field Maintenance table mandates "Set all four triage fields at creation" for Phase 1, but brainstorm.md's issue envelope template only includes kind, status, phase, and updated_at. Add
    eadiness, ask_count, asks_complete, and max_tier to the envelope template.

  • T2: Restore unverified-claim guardrail sentence to brainstorm.md [tier-3]
    Master's old SKILL.md included: "Do not turn an unverified claim into a task requirement, acceptance criterion, or architectural decision without a verification step." The new brainstorm.md preserves the [unverified] marking and "treat it as a hypothesis" guidance but dropped this explicit prohibition. Restore the sentence to the claim classification section.

  • T3: Normalize � vs Section notation in artifact-envelopes.md [tier-3]
    The supersedes field description uses (see �3) while a nearby changed line uses See Section 3 for resolution. Pick one notation and apply consistently.

Acceptance criteria

  • brainstorm.md envelope template includes all four triage fields with sensible defaults
  • Unverified-claim guardrail sentence is present in brainstorm.md
  • artifact-envelopes.md uses consistent section reference notation

Origin

Findings F1�F3 from PR #112 review: #112 (comment)

Authored-by: anthropic/claude-opus-4-6 (claude-code)
Updated-by: openai/gpt-5.4 (codex, effort: high)
Edit-kind: rewrite
Edit-note: Marked all three follow-up tasks complete and refreshed triage metadata after implementing the docs fixes.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions