Skip to content

Updated condition for Gold Label check and passing parameter name passing#18

Merged
ayushbits merged 1 commit intodecile-team:mainfrom
kasuba-badri-vishal:main
Dec 18, 2022
Merged

Updated condition for Gold Label check and passing parameter name passing#18
ayushbits merged 1 commit intodecile-team:mainfrom
kasuba-badri-vishal:main

Conversation

@kasuba-badri-vishal
Copy link
Contributor

  1. Current Version of Spear fails when we are trying to do LF analysis without passing Gold Labels and their values is passed as None and is causing the following error as it is not checked

Y = np.array([self.mapping[v] for v in Y])
TypeError: 'NoneType' object is not iterable

  1. Also their is a function call of confusion_matrix in lf_summary method, which requires the parameter name to execute properly else it fails with following error of argument passing

confusion_matrix(Y, self.L[:, i], labels)[1:, 1:] for i in range(m)
TypeError: confusion_matrix() takes 2 positional arguments but 3 were given

The current code change fixes these two issues.

@ayushbits ayushbits merged commit d855e56 into decile-team:main Dec 18, 2022
@ayushbits
Copy link
Collaborator

Merged. Thanks @kasuba-badri-vishal for PR !

Aziz-Shameem pushed a commit to Aziz-Shameem/spear that referenced this pull request Apr 25, 2023
Updated condition for Gold Label check and passing parameter name passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants