Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bloominstituteoftechnology/JavaScript-II
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: decagondev/JavaScript-II
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 4 files changed
  • 1 contributor

Commits on Aug 7, 2018

  1. Done task 1 and 2

    Tom Tarpey
    Tom Tarpey committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    c19e4ec View commit details
    Browse the repository at this point in the history

  2. refactored task 2 for es5 i'm in a bit of a es6 habbit atm

    Tom Tarpey
    Tom Tarpey committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    11e0fc2 View commit details
    Browse the repository at this point in the history

  3. done task 3

    Tom Tarpey
    Tom Tarpey committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    f22c3ea View commit details
    Browse the repository at this point in the history

  4. done task 4

    Tom Tarpey
    Tom Tarpey committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    44a5dae View commit details
    Browse the repository at this point in the history

  5. cleaned up some debugging and old tests

    Tom Tarpey
    Tom Tarpey committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    1af433a View commit details
    Browse the repository at this point in the history

  6. done stretch item 1

    Tom Tarpey
    Tom Tarpey committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    cf71a49 View commit details
    Browse the repository at this point in the history

  7. done function-conversion stretch es5 to es6 refactor

    Tom Tarpey
    Tom Tarpey committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    183af1c View commit details
    Browse the repository at this point in the history

  8. done the closure stretch counter factory

    Tom Tarpey
    Tom Tarpey committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    cb943a7 View commit details
    Browse the repository at this point in the history

  9. finally after 40mins of reading mdn found a way to do the remove dupl… 

    …icates without the use of a set()
    Tom Tarpey
    Tom Tarpey committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    34d2ec9 View commit details
    Browse the repository at this point in the history

  10. fixed typo in decrement

    Tom Tarpey
    Tom Tarpey committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    9c7db73 View commit details
    Browse the repository at this point in the history

  11. fixed up the return value of counter factory. and refactored one of t… 

    …he functions
    Tom Tarpey
    Tom Tarpey committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    9e46e17 View commit details
    Browse the repository at this point in the history

  12. been reading the IIFE stuff and refactored some of my code

    Tom Tarpey
    Tom Tarpey committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    d2ff72e View commit details
    Browse the repository at this point in the history

  13. rescoped some variables

    Tom Tarpey
    Tom Tarpey committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    f76002f View commit details
    Browse the repository at this point in the history
Loading