Add overview metadata to sqlxconfig#2041
Merged
rahulmadanahalli merged 5 commits intomainfrom Nov 5, 2025
Merged
Conversation
rahulmadanahalli
requested review from
Ceridan,
Tuseeq1,
kolina,
krushangSk17 and
udim
and removed request for
a team
fernst
approved these changes
Nov 5, 2025
| if (config.description) { | ||
| this.description(config.description); | ||
| } | ||
| if (config.metadata) { |
Collaborator
There was a problem hiding this comment.
Can we also add this for Dataprep?
There was a problem hiding this comment.
Let's not to expand on data prep as we want to move everything SQL into regular table action.
Tuseeq1
approved these changes
Nov 5, 2025
chtyim
reviewed
Nov 5, 2025
|
|
||
| message Metadata { | ||
| // A detailed description of the data object. | ||
| string overview = 1; |
There was a problem hiding this comment.
Isn't that we want to allow Metadata to be a map of any key value pairs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.