Skip to content

Dataform Protos - Fix //protos:dataform_proto build#2036

Merged
ikholopov-omni merged 1 commit intodataform-co:mainfrom
ikholopov-omni:fix
Oct 28, 2025
Merged

Dataform Protos - Fix //protos:dataform_proto build#2036
ikholopov-omni merged 1 commit intodataform-co:mainfrom
ikholopov-omni:fix

Conversation

@ikholopov-omni
Copy link
Collaborator

//protos:dataform_proto target has been broken for quite a while with:

dataform/protos/BUILD:7:14: Generating Descriptor Set proto_library //protos:dataform_proto failed: (Exit 1): protoc failed: error executing command bazel-out/k8-py2-opt-exec-2B5CBBC6/bin/external/com_google_protobuf/protoc '--descriptor_
set_out=bazel-out/k8-py2-fastbuild/bin/protos/dataform_proto-descriptor-set.proto.bin' ... (remaining 13 arguments skipped)                                                                                                                                                               
                                                                                                                                                                                                                                                                                          
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging                                                                                                                                                                              
protos/core.proto:29:3: "dataform.DefaultIcebergConfig" seems to be defined in "protos/configs.proto", which is not imported by "protos/core.proto".  To use it here, please add the necessary import. 

This was breaking only this target and not TS/JS code, but we had to fix it manually on the internal imports as well. Adding a missing import, so that the target is passing again and we no longer need to fix it by-hand on internal import.

@ikholopov-omni ikholopov-omni requested a review from a team as a code owner October 28, 2025 10:48
@ikholopov-omni ikholopov-omni requested review from kolina and mfiglus and removed request for a team October 28, 2025 10:48
@ikholopov-omni ikholopov-omni merged commit 096e3ef into dataform-co:main Oct 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants