Dataform Protos - Fix //protos:dataform_proto build#2036
Merged
ikholopov-omni merged 1 commit intodataform-co:mainfrom Oct 28, 2025
Merged
Dataform Protos - Fix //protos:dataform_proto build#2036ikholopov-omni merged 1 commit intodataform-co:mainfrom
ikholopov-omni merged 1 commit intodataform-co:mainfrom
Conversation
kolina
approved these changes
Oct 28, 2025
mfiglus
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//protos:dataform_prototarget has been broken for quite a while with:This was breaking only this target and not TS/JS code, but we had to fix it manually on the internal imports as well. Adding a missing import, so that the target is passing again and we no longer need to fix it by-hand on internal import.