Conversation
Add bazel BUILD support, and script for integrating with Kokoro.
antaresc
approved these changes
Oct 11, 2018
Contributor
antaresc
left a comment
antaresc
left a comment
There was a problem hiding this comment.
Had some small nits, but looks good otherwise!
| https://cloud.google.com/endpoints/docs/frameworks/python/access_from_python | ||
| """ | ||
|
|
||
| from __future__ import absolute_import |
Contributor
There was a problem hiding this comment.
This comment doesn't need to be addressed, but we should write the client API (and other parts) in Python 3. Python 2 is at EOL and won't be supported past 2020.
Contributor
Author
There was a problem hiding this comment.
For my understanding, is adding "from future ..." thing making it less py3 in some way? Or was that just a general comment?
I see that other projects have CI configured in py2 and py3.
Contributor
Author
|
Thanks for the comment! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No real logic change.
Diffs should be about: