Conversation
filipsch
reviewed
Jan 4, 2017
pythonwhat/check_function.py
Outdated
| "You might have to manually specify or correct the signature." | ||
| .format(index=index, name=name)) | ||
|
|
||
| # TODO if can't parse sig, send failed test msg |
Contributor
There was a problem hiding this comment.
is this todo still a todo?
filipsch
approved these changes
Jan 4, 2017
Contributor
filipsch
left a comment
filipsch
left a comment
There was a problem hiding this comment.
I didn't the find the bit where signature = FALSE kicks in by falling back on matching keywords and arguments, but I trust the tests to pass.
Contributor
Author
|
The parser pulls out args for lambdas, function definitions, and calls. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes on validator. Once it looks good to merge, let me know, so I can bump version number.