Merged
Conversation
+1 for opening an issue on scikit-learn and discuss your suggestion (or even a pull request). |
|
If you do a quick sklearn PR it could be part of the 0.20 release. |
Member
Author
|
Will do quick.
…On Thu, Jul 26, 2018 at 11:21 AM Olivier Grisel ***@***.***> wrote:
If you do a quick sklearn PR it could be part of the 0.20 release.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#315 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIlMN2FOutbEgJOYPUBFs2erbTXH1ks5uKeyWgaJpZM4Vgwlc>
.
|
TomAugspurger
added a commit
to TomAugspurger/scikit-learn
that referenced
this pull request
Jul 26, 2018
This lets subclasses re-use more of sklearn.compose._column_transformer. xref dask/dask-ml#315
TomAugspurger
added a commit
to TomAugspurger/scikit-learn
that referenced
this pull request
Jul 26, 2018
This lets subclasses re-use more of sklearn.compose._column_transformer. xref dask/dask-ml#315
Member
Author
|
Scikit-Learn PR at scikit-learn/scikit-learn#11689 This passes locally for me, but won't pass here till dask/dask#3212 and scikit-learn/scikit-learn#11689 are done. |
qinhanmin2014
pushed a commit
to scikit-learn/scikit-learn
that referenced
this pull request
Jul 27, 2018
This lets subclasses re-use more of sklearn.compose._column_transformer. xref dask/dask-ml#315
commit 3f9ba71 Author: Tom Augspurger <[email protected]> Date: Mon Jul 30 14:37:00 2018 -0500 Removed ndarray special casing commit ce632b7 Author: Tom Augspurger <[email protected]> Date: Mon Jul 30 14:20:09 2018 -0500 fix shape commit e570321 Author: Tom Augspurger <[email protected]> Date: Mon Jul 30 14:12:10 2018 -0500 fix shape
commit 764872c Author: Tom Augspurger <[email protected]> Date: Mon Jul 30 14:59:12 2018 -0500 Handle ndarrays gracefully commit 3f9ba71 Author: Tom Augspurger <[email protected]> Date: Mon Jul 30 14:37:00 2018 -0500 Removed ndarray special casing commit ce632b7 Author: Tom Augspurger <[email protected]> Date: Mon Jul 30 14:20:09 2018 -0500 fix shape commit e570321 Author: Tom Augspurger <[email protected]> Date: Mon Jul 30 14:12:10 2018 -0500 fix shape
Member
Author
|
The upstream PRs are in. Merging later today. |
Member
Author
|
Ignoring the coverage failure, since coverage isn't run against sklearn dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a daskified column transformer.
There are two issues preventing us from just using scikit-learn's
.shape( Add (lazy) shape property to dataframe and series dask#3212)sklearn.compose.compose._column_transformer._hstackdoesn't handle dask objects (or pandas dataframes). Just sparse objects and ndarrays. The_hstackimplemented here handles arrays (dask or numpy) dataframes (dask or numpy) and sparse matricies.Long-term, it'd be nice to remove this class entirely, but that'll probably require a lot of work upstream (scipy adopting pydata/sparse, NumPy implementing and libraries adopting
__array_function__).Medium-term,
_hstackcould become a staticmethod onColumnTransformer. Then this subclass would just override_hstack, and everything else could be removed.cc @jorisvandenbossche @ogrisel for that last point. Should I open an issue on scikit-learn to discuss that further?