Skip to content

Add the possibility to set a custom domain#69

Merged
daquinoaldo merged 3 commits into
daquinoaldo:masterfrom
patrikelfstrom:master
Sep 8, 2021
Merged

Add the possibility to set a custom domain#69
daquinoaldo merged 3 commits into
daquinoaldo:masterfrom
patrikelfstrom:master

Conversation

@patrikelfstrom

Copy link
Copy Markdown

Pull Request Details

Related Issue

#68

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation or my changes dont require it.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes (or the existing one were enough).
  • All new and existing tests passed.

Set a custom domain by setting the DOMAIN environment variable.

@daquinoaldo daquinoaldo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you very much! Just a minor comment and we can merge it soon! 🙌

Comment thread README.md Outdated

@daquinoaldo daquinoaldo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll release it in a few days. Thank you for contributing! 🙌

@daquinoaldo daquinoaldo self-assigned this Sep 8, 2021
@daquinoaldo daquinoaldo merged commit 3c8ed5f into daquinoaldo:master Sep 8, 2021
@daquinoaldo

Copy link
Copy Markdown
Owner

Released v4.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants