[Enhancement]: Restrict Users to only sharing Resources to groups they're members of #11267
Replies: 1 comment
-
|
Thanks for the detailed report. This is currently by design, but I understand the concern. How Group Discovery Works TodayFor Entra-synced groups (the primary use case), discoverability is secured by the user's own credentials. When searching for groups, the API uses the user's access token to query Microsoft Graph - so users only see groups their organization's Entra configuration allows them to see. The security boundary is enforced by your identity provider, not LibreChat. The gap you've identified applies to local groups (non-Entra), where search returns all groups without membership filtering. This is less common since most deployments using groups are syncing from Entra and the concept of local groups do not really exist yet. Why the PR Approach Didn't FitThe controller-level validation adds checks on top of our ACL system rather than within it. This leads to:
The proper fix needs to happen in the permission computation layer - treating "can share with group X" as a derivable permission, filtered at query time, and leveraging the membership data we already sync at login. What's NextRelabeling this as a feature request for configurable group sharing restrictions. Key decisions:
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
What happened?
Currently, users can share agents, prompts, and other resources with ANY group in people picker, regardless of whether they are members of that group.
This creates serious security and logical consistency issues.es:
Security/Privacy Issues:
Logical Inconsistency:
Even if we wanted to allow cross-group sharing, the current behavior breaks fundamental consistency: A user can share resources with a group they themselves cannot access. This makes no sense from an access control perspective - if you can't access a group, why should you be able to grant that group access to your resources?
Expected Behavior:
Users should only be able to share resources with groups they are members of. This aligns with:
Version Information
c30afb8
Steps to Reproduce
What browsers are you seeing the problem on?
Chrome, Microsoft Edge
Relevant log output
Screenshots
No response
Code of Conduct
Beta Was this translation helpful? Give feedback.
All reactions