Skip to content

MNT: simplify cibuildwheel configuration #7518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scoder merged 1 commit into from
Feb 11, 2026
Merged

MNT: simplify cibuildwheel configuration #7518

scoder merged 1 commit into from
Feb 11, 2026
+1 −2

Conversation

@neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented Feb 10, 2026

With cibuildwheel 3.x, which you're already using, you don't need to explicitly skip pypy or graalpy: they're already unselected by default. There's also a simpler way to express the minimum Python version supported, that does not require setting up the full [project] table in pyproject.toml

@neutrinoceros neutrinoceros marked this pull request as ready for review February 10, 2026 19:21
@da-woods
Copy link
Contributor

da-woods commented Feb 10, 2026

project-requires-python definitely looks like an improvement.

For me I'd probably prefer to be explicit about PyPy/GraalPy - just because it's a deliberate decision on our part but cibuildwheel could change in future.

@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Feb 10, 2026

updated

@scoder scoder added this to the 3.3 milestone Feb 11, 2026
@scoder scoder merged commit 2cb4fc3 into cython:master Feb 11, 2026
91 of 106 checks passed
@scoder
Copy link
Contributor

scoder commented Feb 11, 2026

Merci.

scoder added a commit that referenced this pull request Feb 11, 2026
@scoder
Revert "MNT: simplify cibuildwheel configuration (GH-7518)"
aaeffda 
This reverts commit 2cb4fc3.
@scoder
Copy link
Contributor

scoder commented Feb 11, 2026

Oh, looks like I somehow missed the fact that the build had failed. I think it's just due to a misnaming of the option.
Probably fixed in 0855989

@neutrinoceros neutrinoceros deleted the mnt/cleanup-cibw-conf branch February 11, 2026 21:07
@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Feb 11, 2026

Whoops, I think I misread the docs. On the bright side, it looks like I also missed that cibuildwheel understands python_requires as a keyword argument to setuptools.setup, which is what should be done here.

@scoder
Copy link
Contributor

scoder commented Feb 12, 2026

cibuildwheel understands python_requires as a keyword argument to setuptools.setup, which is what should be done here.

We already pass that option. I'll try if that suffices.

@scoder
Copy link
Contributor

scoder commented Feb 12, 2026

We already pass that option. I'll try if that suffices.

It doesn't. Time to revert.

scoder added a commit that referenced this pull request Feb 12, 2026
@scoder
Revert "MNT: simplify cibuildwheel configuration (GH-7518)"
5098c32 
This reverts commit 2cb4fc3.
@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Feb 12, 2026

Sorry about this mishap. It looks like a bug in cibuildwheel and I might try fixing it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Build System cleanup

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

3 participants

@neutrinoceros @da-woods @scoder