Conversation
ielvisd
requested changes
Jan 23, 2019
| return contains.includes(items); | ||
| } | ||
|
|
||
| contains(item, function(list) { |
Collaborator
There was a problem hiding this comment.
Everything looks good except for this contains function. Use some console logs here to check your work along the way.
| // The event director needs both the first and last names of each runner for their running bibs. Combine both the first and last names into a new array called fullName. | ||
| let fullName = []; | ||
|
|
||
| runners.forEach(function(firstName, lastName) { |
Collaborator
There was a problem hiding this comment.
You only need to pass one thing into the function because you are already doing something forEach item you pass
|
|
||
| console.log(fullName); | ||
|
|
||
| // ==== Challenge 2: Use .map() ==== |
Collaborator
There was a problem hiding this comment.
use .map (refer to the MDN) documentation for array methods for some examples. Same for .filter
| speak('Yo'); | ||
|
|
||
|
|
||
| // ==== Challenge 2: Create a counter function ==== |
Collaborator
There was a problem hiding this comment.
You're almost there for challenge 2, throw some console.logs in there to check your work as you work through your function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.