Skip to content

Conversation

@anmolsahoo25
Copy link

🚨Please review the guidelines for contributing to this repository.

Proposed changes

Updated the file retrieve code to get the files by adding the headers to the opener.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [x ] I have read the CONTRIBUTING doc
  • [x ] I agree to contribute my changes under the project's LICENSE
  • [ x] I have checked that the unit tests pass locally with my changes
  • [ x] I have checked the style of the new code (lint/pep).
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [ x] I have added necessary documentation (if appropriate)

Further comments

Reviewers

@rbrito

@coveralls
Copy link

coveralls commented Mar 11, 2018

Coverage Status

Coverage decreased (-0.3%) to 47.7% when pulling f5ff849 on anmolsahoo25:fix-0-courses-available into b6c77a6 on coursera-dl:fix-0-courses-available.

Copy link

@ahmedMyounes ahmedMyounes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change line 121 and 122 to
EDX_HOMEPAGE = BASE_URL + '/login'
LOGIN_API = BASE_URL + '/login'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants