Added support for the <br> tag and support for nested assets in the t…#14
Conversation
|
We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch. |
|
ishaileshmishra
left a comment
ishaileshmishra
left a comment
There was a problem hiding this comment.
Please refer the comment
Code implementation done and added test cases. |
ishaileshmishra
left a comment
ishaileshmishra
left a comment
There was a problem hiding this comment.
Added on minor change
|
Reviewed, found code implementation missing. Please complete the code implementation @sunil-lakshman |
Done |
ishaileshmishra
left a comment
ishaileshmishra
left a comment
There was a problem hiding this comment.
Approved.
Please share the pull request (PR) details with Gautam for the CAB and also submit a request to the SRE team for code review.
#14) (#15) * Added support for the <br> tag and support for nested assets in the the image * Added version and change log * Added Testcases * Resolved dependency gem issues in latest ruby versions * Added test case for break tag * Changed tag to full name * Changed method name from 'text_to_htms' to 'text_to_html' * Changed version from 1.1.4 to 1.2.0
2 participants
No description provided.