Merged
Conversation
* Feat/cs 37229 azure eu and include metadata * Added new method for custom host support with different regions
Feat/cs 37229 azure eu and include metadata (#32)
Member
ishaileshmishra
left a comment
ishaileshmishra
left a comment
There was a problem hiding this comment.
You have added 2 feature in the code
- include_metadata
- Region support for Azure-EU
Test cases added partially for the include_metadata. and there are no testcase added for the region support.
Member
ishaileshmishra
left a comment
ishaileshmishra
left a comment
There was a problem hiding this comment.
1 change : Use Protocol = 'https://'
uttamukkoji
reviewed
Apr 21, 2023
aravindbuilt
approved these changes
Apr 25, 2023
Member
|
Conversation is not closed that is why it is blocked to merge. Please resolve all the conversations. @sunil-lakshman |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby - Azure-EU and include_metadata Implementation in Ruby Delivery SDK
Adding Region Support for Azure-EU
Adding support for include_metadata in Asset, Entry and Query classes.