Skip to content

Bug/cs 42703 updating entry with file#96

Merged
abhinav-from-contentstack merged 3 commits intonextfrom
bug/CS-42703-updating-entry-with-file
Dec 13, 2023
Merged

Bug/cs 42703 updating entry with file#96
abhinav-from-contentstack merged 3 commits intonextfrom
bug/CS-42703-updating-entry-with-file

Conversation

@abhinav-from-contentstack
Copy link
Contributor

@abhinav-from-contentstack abhinav-from-contentstack commented Dec 12, 2023 •
edited
Loading

  • released with version 1.14.0
  • added fix for issue while updating entries with assets

@abhinav-from-contentstack abhinav-from-contentstack requested a review from a team as a code owner December 12, 2023 06:41
@github-actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

Coverage report for commit: b17a988
File: coverage/clover.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ █████████░░░░░░░░░░░░░░ │ 16.3%
  90% │ ███████████████████████ │ 44.2%
 100% │ █████████████████████░░ │ 39.5%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution
Summary - Lines: 90.27% | Methods: 97.79% | Branches: 73.32%
FilesLinesMethodsBranches
lib/app/authorization
   index.js91.67%100.00%72.09%
lib/app/hosting
   deployment.js85.29%100.00%65.79%
   index.js80.70%100.00%59.09%
lib/app
   index.js92.78%100.00%66.12%
lib/app/installation
   index.js84.62%100.00%59.55%
lib/app/request
   index.js91.43%100.00%65.85%
lib
   contentstack.js100.00%100.00%100.00%
   contentstackClient.js100.00%100.00%85.00%
   contentstackCollection.js100.00%100.00%100.00%
   entity.js85.00%100.00%62.75%
lib/core
   Util.js96.36%100.00%83.64%
   concurrency-queue.js94.19%100.00%85.71%
   contentstackError.js100.00%100.00%100.00%
   contentstackHTTPClient.js98.08%100.00%93.75%
lib/organization
   index.js83.33%100.00%60.67%
lib/organization/teams
   index.js92.11%100.00%68.42%
lib/organization/teams/stackRoleMappings
   index.js89.29%100.00%58.14%
lib/organization/teams/teamUsers
   index.js93.33%75.00%93.75%
lib/query
   index.js80.43%100.00%67.27%
lib/stack/asset/folders
   index.js100.00%100.00%100.00%
lib/stack/asset
   index.js85.29%84.21%64.94%
lib/stack/auditlog
   index.js95.83%100.00%75.76%
lib/stack/branch
   compare.js81.82%100.00%71.88%
   index.js97.44%100.00%80.56%
   mergeQueue.js100.00%100.00%73.68%
lib/stack/branchAlias
   index.js86.21%100.00%65.85%
lib/stack/contentType/entry
   index.js91.04%100.00%73.77%
lib/stack/contentType
   index.js83.02%85.71%70.18%
lib/stack/deliveryToken
   index.js100.00%100.00%94.44%
lib/stack/environment
   index.js100.00%100.00%100.00%
lib/stack/extension
   index.js95.92%100.00%87.76%
lib/stack/globalField
   index.js94.12%100.00%83.78%
lib/stack
   index.js84.44%87.18%73.16%
lib/stack/label
   index.js100.00%100.00%100.00%
lib/stack/locale
   index.js100.00%100.00%100.00%
lib/stack/release
   index.js91.11%100.00%72.34%
lib/stack/roles
   index.js100.00%100.00%100.00%
lib/stack/taxonomy
   index.js92.59%100.00%75.00%
lib/stack/taxonomy/terms
   index.js92.31%100.00%72.55%
lib/stack/webhook
   index.js89.66%100.00%72.88%
lib/stack/workflow
   index.js89.09%100.00%72.31%
lib/stack/workflow/publishRules
   index.js100.00%100.00%100.00%
lib/user
   index.js94.29%100.00%82.14%

🤖 comment via lucassabreu/comment-coverage-clover

@abhinav-from-contentstack
Copy link
Contributor Author

abhinav-from-contentstack commented Dec 12, 2023

These action points were identified during the Code Review

@abhinav-from-contentstack
Copy link
Contributor Author

abhinav-from-contentstack commented Dec 13, 2023

Hi @nadeem-cs, I've added API tests.
And the code is being completely covered in unit test cases.
image

cc : @ishaileshmishra

nadeem-cs
nadeem-cs approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@nadeem-cs nadeem-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@abhinav-from-contentstack abhinav-from-contentstack deleted the bug/CS-42703-updating-entry-with-file branch December 13, 2023 09:39
sunil-lakshman pushed a commit that referenced this pull request Jun 26, 2024
@abhinav-from-contentstack
Merge pull request #96 from contentstack/bug/CS-42703-updating-entry-…
3487f74 
…with-file

Bug/cs 42703 updating entry with file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nadeem-cs nadeem-cs nadeem-cs approved these changes

@ishaileshmishra ishaileshmishra Awaiting requested review from ishaileshmishra

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abhinav-from-contentstack @nadeem-cs @harshithad0703