Conversation
laliconfigcat
approved these changes
Aug 23, 2023
adams85
reviewed
Aug 28, 2023
adams85
requested changes
Aug 28, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
adams85
approved these changes
Aug 28, 2023
adams85
reviewed
Aug 28, 2023
| * @return float the last download time of the current config in unix milliseconds format. | ||
| */ | ||
| public function getFetchTimeUnixSeconds(): int | ||
| public function getFetchTimeUnixMilliseconds(): float |
Contributor
There was a problem hiding this comment.
This is a BC to a public API, so I guess it should be mentioned in the release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
This PR enables the generalized caching feature.
Related issues (only if applicable)
Requirement checklist (only if applicable)