chore(deps): bump CodSpeedHQ/action from 4.10.2 to 4.10.5#369
chore(deps): bump CodSpeedHQ/action from 4.10.2 to 4.10.5#369shenxianpeng merged 2 commits intomainfrom
Conversation
dependabot
bot
added
dependencies
dependabot
bot
requested review from
shenxianpeng
and removed request for
a team
dependabot
bot
added
github_actions
✅ Deploy Preview for commit-check ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
shenxianpeng
left a comment
shenxianpeng
left a comment
There was a problem hiding this comment.
Benchmark CI failed. need to take a look @copilot
|
@shenxianpeng I've opened a new pull request, #370, to work on those changes. Once the pull request is ready, I'll request review from you. |
Bumps [CodSpeedHQ/action](https://github.com/codspeedhq/action) from 4.10.2 to 4.10.5. - [Release notes](https://github.com/codspeedhq/action/releases) - [Changelog](https://github.com/CodSpeedHQ/action/blob/main/CHANGELOG.md) - [Commits](CodSpeedHQ/action@2084259...9a74b6b) --- updated-dependencies: - dependency-name: CodSpeedHQ/action dependency-version: 4.10.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
shenxianpeng
force-pushed
the
dependabot/github_actions/CodSpeedHQ/action-4.10.5
branch
from
ce0ec77 to
bc6cffc
Compare
* fix: mock git author in test_positional_arg_invalid_commit The test was failing in CI because the git author (copilot[bot]) was in the ignore_authors list, causing validation to be skipped and return 0 instead of 1. Added mocker parameter and mock to ensure the author is not ignored. Co-authored-by: shenxianpeng <[email protected]> * fix: update to fix lint failed --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: shenxianpeng <[email protected]> Co-authored-by: shenxianpeng <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
+ Coverage 94.65% 95.03% +0.37%
==========================================
Files 9 9
Lines 805 805
==========================================
+ Hits 762 765 +3
+ Misses 43 40 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will improve performance by 59.17%
Performance Changes
Comparing 
Footnotes
|
There was a problem hiding this comment.
Pull request overview
Updates the CodSpeed GitHub Actions benchmark workflow to use CodSpeedHQ/action v4.10.5, and adjusts a CLI positional-argument test to be stable when the current git author could be ignored by config.
Changes:
- Bump CodSpeedHQ/action pin in the CodSpeed workflow from v4.10.2 to v4.10.5.
- Update
test_positional_arg_invalid_committo mockget_commit_infoso commit validation won’t be skipped due to an ignored author.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/codspeed.yml |
Updates CodSpeed action pin to v4.10.5 for benchmark runs. |
tests/main_test.py |
Stabilizes invalid-commit positional-arg test by mocking author lookup. |
| def test_positional_arg_invalid_commit(self, mocker): | ||
| """Test that positional argument correctly rejects invalid commits.""" | ||
| # Mock git author to ensure it's not in any ignore list | ||
| mocker.patch("commit_check.engine.get_commit_info", return_value="test-author") | ||
|
|
There was a problem hiding this comment.
This PR is titled/described as only a CodSpeed action version bump, but it also changes test behavior by mocking get_commit_info. Please update the PR description/title to reflect this additional change, or split the test fix into a separate PR to keep the dependency bump reviewable and easily revertible.
shenxianpeng
deleted the
dependabot/github_actions/CodSpeedHQ/action-4.10.5
branch
Bumps CodSpeedHQ/action from 4.10.2 to 4.10.5.
Release notes
Sourced from CodSpeedHQ/action's releases.
... (truncated)
Commits
9a74b6bRelease v4.10.5 🚀d6fbd84chore: bump runner version to 4.10.5fa0c9b1Release v4.10.4 🚀af115eechore: bump runner version to 4.10.47bb457dchore: bump runner version to 4.10.3Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)