Skip to content

Comments

fix: update imperatives.py and bump pre-commit hooks#312

Merged
shenxianpeng merged 5 commits intomainfrom
fix/patch-2
Oct 20, 2025
Merged

fix: update imperatives.py and bump pre-commit hooks#312
shenxianpeng merged 5 commits intomainfrom
fix/patch-2

Conversation

@shenxianpeng
Copy link
Contributor

@shenxianpeng shenxianpeng commented Oct 20, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Commit message checks now recognize "bump" as a valid imperative, reducing false rejections for commits that start with that verb.

  • Chores

    • Updated pre-commit tooling to newer releases for improved linting and commit validation.

@shenxianpeng shenxianpeng requested a review from a team as a code owner October 20, 2025 19:50
@netlify
Copy link

netlify bot commented Oct 20, 2025 •
edited
Loading

✅ Deploy Preview for commit-check ready!

Name Link
🔨 Latest commit c467b9f
🔍 Latest deploy log https://app.netlify.com/projects/commit-check/deploys/68f69952b78ce90008556c48
😎 Deploy Preview https://deploy-preview-312--commit-check.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the bug Something isn't working label Oct 20, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2025 •
edited
Loading

Warning

Rate limit exceeded

@shenxianpeng has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 4 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ca1bebb and c467b9f.

📒 Files selected for processing (3)
  • .pre-commit-config.yaml (2 hunks)
  • .pre-commit-hooks.yaml (1 hunks)
  • docs/example.rst (1 hunks)

Walkthrough

Added the string "bump" to the top-level IMPERATIVES set in commit_check/imperatives.py, and updated two hooks' revisions in .pre-commit-config.yaml (astral-sh/ruff-pre-commit to v0.14.1, commit-check/commit-check to v2.0.0).

Changes

Cohort / File(s) Summary
Imperative verbs expansion
commit_check/imperatives.py		 Added the "bump" element to the top-level IMPERATIVES set constant.
Pre-commit hook updates
.pre-commit-config.yaml		 Bumped hook revisions: astral-sh/ruff-pre-commit updated to v0.14.1; commit-check/commit-check updated to v2.0.0. No other config changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

enhancement

Poem

🐰 I nibbled a word, added "bump" with delight,
Hopped through hooks, made versions shine bright,
A tiny change, snug and light,
Commit skies clearer, soft and white. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "fix: Update imperatives.py to bump pre-commit hooks" is partially related to the changeset. The title correctly identifies that imperatives.py is being updated and references bumping/updating, which corresponds to both changes in the PR: adding "bump" to the IMPERATIVES set and updating pre-commit hook versions in .pre-commit-config.yaml. However, the phrasing "to bump pre-commit hooks" is somewhat ambiguous—it could be interpreted either as adding the word "bump" to imperatives or as updating hook versions—and doesn't fully clarify that the primary change is adding a new imperative verb to the set.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Oct 20, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 126bf34 and f5c43f3.

📒 Files selected for processing (1)
  • commit_check/imperatives.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Run benchmarks

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #312 will degrade performances by 39.88%

Comparing fix/patch-2 (c467b9f) with main (126bf34)

Summary

❌ 1 regression
✅ 155 untouched
⏩ 85 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ test_main_with_message_empty_string_no_stdin_with_git 4.7 ms 7.7 ms -39.88%

Footnotes

  1. 85 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@shenxianpeng @coderabbitai
chore: Update commit_check/imperatives.py
51884ab 
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@shenxianpeng shenxianpeng changed the title chore: Update imperatives.py fix: Update imperatives.py to add 'bump' Oct 20, 2025
@shenxianpeng shenxianpeng changed the title fix: Update imperatives.py to add 'bump' fix: Update imperatives.py to bump pre-commit hooks Oct 20, 2025
@codecov
Copy link

codecov bot commented Oct 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.29%. Comparing base (126bf34) to head (c467b9f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   87.15%   87.29%   +0.14%     
==========================================
  Files           8        8              
  Lines         685      685              
==========================================
+ Hits          597      598       +1     
+ Misses         88       87       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 20, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@shenxianpeng shenxianpeng merged commit dae467f into main Oct 20, 2025
34 of 36 checks passed
@shenxianpeng shenxianpeng deleted the fix/patch-2 branch October 20, 2025 20:27
@shenxianpeng shenxianpeng changed the title fix: Update imperatives.py to bump pre-commit hooks fix: update imperatives.py and bump pre-commit hooks Oct 20, 2025
@coderabbitai coderabbitai bot mentioned this pull request Nov 4, 2025
Closed
This was referenced Feb 2, 2026
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Feb 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shenxianpeng