chore: add oidc redirect url to override access url#21521
Open
chore: add oidc redirect url to override access url#21521
Conversation
If a deployment has 2 domains, overriding the oidc url allows the oidc redirect to differ from the access_url
Emyrk
force-pushed
the
stevenmasley/oidc_redirect_url
branch
from
086aa16 to
00072fa
Compare
Member
Author
|
I manually QA'd this on localhost and got it working. The original reported also reported this is a valid fix: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a deployment has 2 domains, overriding the oidc url allows the oidc redirect to differ from the access_url
response to #21500