Conversation
jsjoeio
commented
Jan 26, 2021
jsjoeio
force-pushed
the
add-playwright
branch
from
4a50ddc to
98da30c
Compare
jsjoeio
commented
Jan 28, 2021
jsjoeio
force-pushed
the
add-playwright
branch
from
98da30c to
96add41
Compare
jsjoeio
commented
Jan 28, 2021
Contributor
Author
|
The macos error looks like it was a network connection error: |
oxy
reviewed
Jan 28, 2021
oxy
left a comment
oxy
left a comment
There was a problem hiding this comment.
Looks alright to me! Haven't worked much on testing so far - so you might want a second opinion.
jsjoeio
force-pushed
the
add-playwright
branch
from
96add41 to
2b7dfa4
Compare
code-asher
reviewed
Jan 29, 2021
Contributor
Author
|
Seeing strange errors in the macos release
|
Contributor
Author
|
Re-running tests |
jsjoeio
force-pushed
the
add-playwright
branch
from
e6cbf0e to
6685a3e
Compare
jsjoeio
dismissed
code-asher’s stale review
I made your changes and Anmol approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds playwright for end-to-end testing. In ci, we now download the code-server artifact, run code-server in ci and then run tests against it.
Changes
playwrightto/test/package.jsonci.ymltestjob to work withe2eAdditional Notes
Right now,
yarn testruns both the unit and the e2e tests. This means it will fail locally if you do not havecode-serverrunning. In the future, we should consider separating the tests. We could havetest:unitandtest:e2eand then have separate jobs for each in ci.Follow-up issue: #2646
Todos
pkill nodein ci job