remove code-studio js firehose events #70115
Conversation
| appType: this.getStandaloneAppForMetrics(), | ||
| channelId: this.getCurrentId(), | ||
| }); | ||
|
|
There was a problem hiding this comment.
Does this return value matter? I'm not sure what putRecord returns (a promise?) This does change the signature of this function, tho I'm not sure it's consequences.
There was a problem hiding this comment.
Yes it did. this was the cause of a UI test failure which has been fixed in the latest commit
|
@fisher-alice In #70190. it seemed like we want to keep the firehose logging in |
Hi Alex! We added Cloudwatch logging, but are still tweaking to make sure we are capturing all data (error logs and save vs save failure counts). We've received quite a few Zendesk reports about progress/project save failures the past quarter, so the longitudinal firehose data provides is still very useful in seeing if this is a recent trend or not. We want to ensure that Cloudwatch logging is consistent with Firehose logging. Also, it would be helpful to get an estimate of the percent data loss of Firehose data over time compared to Cloudwatch. See Darrin's comment at https://codedotorg.slack.com/archives/C03DBDN67B7/p1762206237204139?thread_ts=1760898557.677259&cid=C03DBDN67B7 So maybe we could keep 'project-data-integrity' firehose logging for another 3-6 months? |
Gotcha. I'll hold off on removing those firehose logs for now. Thanks for the context! |
Thanks so much! |
3 participants
This PR is one of several PRs to remove JavaScript firehose events in order to better streamline our logging pipelines.
Links
Related work