Skip to content

Conversation

@SumitGupta016
Copy link
Contributor

@SumitGupta016 SumitGupta016 commented Jun 18, 2025

Added option for the number of rows to 3.
This PR should close the issue: #3008

@ImprovedTube
Copy link
Member

hi! @SumitGupta016
then what about 1,2,...,9,10,12,13,14?


(used to make the default the first one )


btw/@walbo seems our drop downs elements have no default value and can't be reset? until merging this if (this.value == defValue) { component.storage.remove(); from #2462, deb8f0f )

@SumitGupta016
Copy link
Contributor Author

hi! @SumitGupta016 then what about 1,2,...,9,10,12,13,14?

(used to make the default the first one )

btw/@walbo seems our drop downs elements have no default value and can't be reset? until merging this if (this.value == defValue) { component.storage.remove(); from #2462, deb8f0f )

so the problem statement was about to add 3 from 4 so that why i added 3 as an option so it would pick, let me know if it's required any specific values also?

@wbalbo
Copy link
Contributor

wbalbo commented Jun 20, 2025

hi! @SumitGupta016 then what about 1,2,...,9,10,12,13,14?

(used to make the default the first one )

btw/@walbo seems our drop downs elements have no default value and can't be reset? until merging this if (this.value == defValue) { component.storage.remove(); from #2462, deb8f0f )

Yeah, I guess. The default value is useful sometimes.

About other options for thumbs, I guess we already covered the most requested ones, not? Maybe we should wait for new issues for other values to add? To avoid cluttering with too many options that most people will never use.

@SumitGupta016
Copy link
Contributor Author

hi! @SumitGupta016 then what about 1,2,...,9,10,12,13,14?
(used to make the default the first one )
btw/@walbo seems our drop downs elements have no default value and can't be reset? until merging this if (this.value == defValue) { component.storage.remove(); from #2462, deb8f0f )

Yeah, I guess. The default value is useful sometimes.

About other options for thumbs, I guess we already covered the most requested ones, not? Maybe we should wait for new issues for other values to add? To avoid cluttering with too many options that most people will never use.

ummm... ok so I guess this PR is gonna be draft until we have a confirmation about the other defaults to be added?

@wbalbo
Copy link
Contributor

wbalbo commented Jun 20, 2025

hi! @SumitGupta016 then what about 1,2,...,9,10,12,13,14?
(used to make the default the first one )
btw/@walbo seems our drop downs elements have no default value and can't be reset? until merging this if (this.value == defValue) { component.storage.remove(); from #2462, deb8f0f )

Yeah, I guess. The default value is useful sometimes.
About other options for thumbs, I guess we already covered the most requested ones, not? Maybe we should wait for new issues for other values to add? To avoid cluttering with too many options that most people will never use.

ummm... ok so I guess this PR is gonna be draft until we have a confirmation about the other defaults to be added?

In my opinion, your code should be merged, it's fine and doing what is supposed to do, but the "boss" is @ImprovedTube haha

@SumitGupta016
Copy link
Contributor Author

hi! @SumitGupta016 then what about 1,2,...,9,10,12,13,14?
(used to make the default the first one )
btw/@walbo seems our drop downs elements have no default value and can't be reset? until merging this if (this.value == defValue) { component.storage.remove(); from #2462, deb8f0f )

Yeah, I guess. The default value is useful sometimes.
About other options for thumbs, I guess we already covered the most requested ones, not? Maybe we should wait for new issues for other values to add? To avoid cluttering with too many options that most people will never use.

ummm... ok so I guess this PR is gonna be draft until we have a confirmation about the other defaults to be added?

In my opinion, your code should be merged, it's fine and doing what is supposed to do, but the "boss" is @ImprovedTube haha

yes, so what should we do is merge this one and should'nt close the issue instead we would update it for something like to add more defaults for thumbnail or something. I don't know

@wbalbo
Copy link
Contributor

wbalbo commented Jun 20, 2025

hi! @SumitGupta016 then what about 1,2,...,9,10,12,13,14?
(used to make the default the first one )
btw/@walbo seems our drop downs elements have no default value and can't be reset? until merging this if (this.value == defValue) { component.storage.remove(); from #2462, deb8f0f )

Yeah, I guess. The default value is useful sometimes.
About other options for thumbs, I guess we already covered the most requested ones, not? Maybe we should wait for new issues for other values to add? To avoid cluttering with too many options that most people will never use.

ummm... ok so I guess this PR is gonna be draft until we have a confirmation about the other defaults to be added?

In my opinion, your code should be merged, it's fine and doing what is supposed to do, but the "boss" is @ImprovedTube haha

yes, so what should we do is merge this one and should'nt close the issue instead we would update it for something like to add more defaults for thumbnail or something. I don't know

Maybe, I personally prefer to create a new issue for the other issue, because it's pretty easy to lose some ideas in a sea of mixed discussions about different things, but anyway is fine for me.

Thanks.

@ImprovedTube ImprovedTube added the Knowledge Base / Documentation for contributors We should repurpose this for future reference / Wiki / Education / Introduction label Jun 22, 2025
@ImprovedTube ImprovedTube merged commit 6f71559 into code-charity:master Jun 22, 2025
@ImprovedTube
Copy link
Member

ummm...

it's optional but nice to have a dense / combined GitHub commit history. The second commit fits your title.
Did you test the option '3'? Welcome to the team! @SumitGupta016

(used to make the default the first one )

Yet we listed Youtube's standards first in drop down settings. Such as 100% and 4 here?

About other options for thumbs, I guess we already covered the most requested ones, not? Maybe we should wait for new issues for other values to add? To avoid cluttering with too many options that most people will never use.

what about? 7f1e59f
who isn't interested in the feature needs not to click it. Once clicking, only who likes the extra options needs to look at them. (Who is looking for 3 or 5 can stop looking down further.)

Another principle? 'Everything as a work in progress'

btw/@walbo seems our drop downs elements have no default value and can't be reset? until merging this if (this.value == defValue) { component.storage.remove(); from #2462, deb8f0f )

In other words: "Project-Architecture": Our select element (drop down) is unfinished. Nothing should happen when '4' is set? Because that is Youtube's default? Yet if a user tests '5' and goes back to 4, then the number 4 is stored and 4 will be attempted needlessly until we fix that? (In the feature code (quick fix) or in the GUI element in our (GUI-)library satus.js).
While custom GUI elements are more flexible / standard JS, we also still lack tab-key-navigation (#2206), unlike standard html elements.

@ImprovedTube
Copy link
Member

default

default

default

In other words 😃 ( @wbalbo @SumitGupta016 )

youtube defaults

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Knowledge Base / Documentation for contributors We should repurpose this for future reference / Wiki / Education / Introduction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants