-
-
Notifications
You must be signed in to change notification settings - Fork 796
fix: updated number of rows per row #3011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated number of rows per row #3011
Conversation
|
hi! @SumitGupta016
btw/@walbo seems our drop downs elements have no default value and can't be reset? until merging this |
so the problem statement was about to add 3 from 4 so that why i added 3 as an option so it would pick, let me know if it's required any specific values also? |
Yeah, I guess. The default value is useful sometimes. About other options for thumbs, I guess we already covered the most requested ones, not? Maybe we should wait for new issues for other values to add? To avoid cluttering with too many options that most people will never use. |
ummm... ok so I guess this PR is gonna be draft until we have a confirmation about the other defaults to be added? |
In my opinion, your code should be merged, it's fine and doing what is supposed to do, but the "boss" is @ImprovedTube haha |
yes, so what should we do is merge this one and should'nt close the issue instead we would update it for something like |
Maybe, I personally prefer to create a new issue for the other issue, because it's pretty easy to lose some ideas in a sea of mixed discussions about different things, but anyway is fine for me. Thanks. |
it's optional but nice to have a dense / combined GitHub commit history. The second commit fits your title. Yet we listed Youtube's standards first in drop down settings. Such as 100% and 4 here?
what about? 7f1e59f Another principle? 'Everything as a work in progress'
In other words: |
In other words 😃 ( @wbalbo @SumitGupta016 ) |





Added option for the number of rows to 3.
This PR should close the issue: #3008