Support Python 2.7, 3.4, 3.5, 3.6 - #17
Merged
Merged
Conversation
Version unimportant; all versions of `six` have the (basic) functionality we need, and those "moves" imports are core parts of the package which would be catastrophic to change in the future.
This was suggested by 2to3, and may as well commit it.
2to3 didn't like these, and converted all of these to just 'raise Exception', so match normal Python idioms a little closer.
Contributor
|
Sorry for accidentally closing! Thanks for the PR, @mruffalo. There are a few things we want to review first, but from a glance, the changes look great. |
Contributor
|
Thanks for taking the time to do this, @mruffalo! Appreciate it. |
Contributor
Author
|
My pleasure! This was much less work than a similar pull request I made in the old l1ktools repository: https://github.com/cmap/l1ktools/pull/14 -- especially since this code was written using modern Python 2.x idioms/style, which really eases the process of making it run under 3.x also. It was also very useful to already have Travis CI testing in place. |
Contributor
|
@mruffalo that was the whole idea behind refactoring it, so I'm very happy to hear it's not just us who find it easier to work with! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not many changes were required:
sixpackage for a few renamed modules/builtin functions/etc.__future__.print_functionimport intest_concat_gctoo.pyAll tests passed under 2.7, 3.4, 3.5, and 3.6, as per an older Travis CI build at https://travis-ci.org/mruffalo/cmapPy/builds/294957365 -- though that build is from an older version of these changes which also included testing Python 3.3. I'm sure everything will work under Python 3.3 also, but the
h5pypackage fails to install under 3.3 on the Travis CI service, so that version probably shouldn't be marked as "supported" without any test coverage.