RangeSetND: avoid quadratic padding scan in iter_padding() - #706
Open
thiell wants to merge 1 commit into
Open
Conversation
RangeSet.padding is a property that walks the whole set, so computing it for each yielded item made iter_padding() quadratic. Compute it once per vector instead; each item still gets its own list. Point to the faster pads() in the docstring. Signed-off-by: Stephane Thiell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RangeSet.paddingis a property that walks the whole set; computing it for each yielded item madeiter_padding()quadratic on large sets.pads()when per-item padding info is not needed.