Fix broken contributing link on PyPI#726
Merged
cjolowicz merged 2 commits intocjolowicz:mainfrom Dec 11, 2021
Merged
Conversation
cjolowicz
reviewed
Dec 9, 2021
Owner
cjolowicz
left a comment
cjolowicz
left a comment
There was a problem hiding this comment.
Thanks for catching this!
The problem with your approach is that it will silently switch versions on Read the Docs.
Owner
|
Better keep the pros:
cons:
I think the pros outweigh the cons. Like you say, PyPI readers will get the GitHub version which is less polished. But it's the Contributor Guide, contributors want to go to GitHub anyway 😉 |
Contributor
Author
|
@cjolowicz oh I see the problem. Ok, I fix that later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-onlyRST session and put full paths to RTD it simply works everywhere.I tried in my own repo, you can check out: https://pypi.org/project/git-portfolio/
Closes cjolowicz/cookiecutter-hypermodern-python#1091