✨ [nox] Support patching pre-commit hooks written in bash#718
Merged
✨ [nox] Support patching pre-commit hooks written in bash#718
Conversation
Owner
Author
|
The patched hooks have an issue on Git Bash for Windows, where the path separator This issue is fixed by #721. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit 2.16.0 switched from Python to bash in the hooks installed to
.git/hooks. We're patching hook scripts to activate the virtualenv for thepre-commitNox session. This PR teaches the Nox session to detect bash hooks. The inserted fragment for virtualenv activation was ported to bash.This PR also fixes a potential crash when files in the hook directory cannot be opened using the default text encoding. We're now checking that the binary file contents start with the shebang sequence
#!before attempting to decode the contents. That should at least deal with binaries. Scripts with random garbage will still cause the hook installation to crash.if not continuewithifpatchespatchesif...elifwithfor...if...breakloop overpatchespatcheskeysheaderpatchestoheaderspatchtoheaderbindirsbefore loopbindirsintobindirsheadersbefore looplines[0].startswithwithhook.read_bytes().startswith