Remove any use of process.cwd(), and clean up directory options across functions#40
Merged
Remove any use of process.cwd(), and clean up directory options across functions#40
Conversation
- Use `cwd` consistently across functions - Remove unnecessary extra directory args for `commitChangesFromRepo` - Introduce `recursivelyFindRoot` argument
Andarist
reviewed
May 10, 2025
| - For `commitFilesFromDirectory`: | ||
| - Rename `workingDirectory` to `cwd` for consistency across repos, | ||
| and utils like `exec` | ||
| - Make `cwd` a required argument |
Member
There was a problem hiding this comment.
It would be OK to make this optional and just default to process.cwd(). In changesets/action we'd still provide it explicitly though.
Member
Author
There was a problem hiding this comment.
Yeah, decided being explicit was probably better anyway, given how easy it is to use process.cwd() if that's what people wanted. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #39 by ntroducing breaking changes to how we require directories to be specified in the arguments to 2 key functions.
Full information in the
.changesetsfolder, but TL;DR:cwdis now used as the directory name in both files (brings consistency with https://github.com/changesets/action)cwdis required (no default use ofprocess.cwd())commitChangesFromRepoargs have been simplified to only require 1 directoryfixes #39