ui: fix journal parsing in ProgressView#2085
Merged
Chris-Peterson444 merged 1 commit intoSep 17, 2024
Merged
Conversation
The ProgressView.other_event function splits messages on the ":" character to get the context type and the message from journal messages. This code will crash if the message has more than one ":" character. When passing cloud-config with invalid top level keys, subiquity will check these keys and report on the journal with a message: "cloud-init schema validation failure for: <key1> [, <key2>, ...]", which was causing the UI to crash repeatedly. LP: #2080918
Contributor
Author
|
I was pretty sure I tested this out in Noble before and didn't run into this, but I can recreate it with the Noble release ISO. |
dbungert
approved these changes
Sep 17, 2024
ogayot
approved these changes
Sep 17, 2024
Collaborator
|
doh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ProgressView.other_event function splits messages on the ":" character to get the context type and the message from journal messages. This code will crash if the message has more than one ":" character. When passing cloud-config with invalid top level keys, subiquity will check these keys and report on the journal with a message: "cloud-init schema validation failure for: [, , ...]", which was causing the UI to crash repeatedly.
LP: #2080918