Skip to content

fix: remove duplicate "Name" label on team creation page#27803

Merged
dhairyashiil merged 1 commit intomainfrom
devin/1770654566-fix-team-name-duplicate-label
Feb 10, 2026
Merged

fix: remove duplicate "Name" label on team creation page#27803
dhairyashiil merged 1 commit intomainfrom
devin/1770654566-fix-team-name-duplicate-label

Conversation

@CarinaWolli
Copy link
Copy Markdown
Member

What does this PR do?

Fixes a duplicate label bug on the team creation page (/settings/teams/new). The name input was showing both "Team name" (from an explicit <Label> component) and "Name" (auto-generated by TextField from name="name" via label = t(name)).

Adds noLabel to the TextField so only the explicit "Team name" label is rendered.

Before:

before

After:

Only "Team name" label is shown above the input.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A
  • I confirm automated tests are in place that prove my fix is effective or that my feature works. N/A — visual-only label fix.

How should this be tested?

  1. Navigate to /settings/teams/new
  2. Verify the name input field shows only one label: "Team name"
  3. Confirm the input still functions correctly (typing, form submission)

Human Review Checklist

  • Accessibility: The external <Label> on line 166 does not have a htmlFor prop linking it to the input. The TextField's internal label (now suppressed) was the one providing htmlFor={id}. Reviewer should consider whether the external <Label> should be removed in favor of passing label={t("team_name")} directly to TextField, which would preserve the htmlFor association.

Link to Devin run: https://app.devin.ai/sessions/d51db26abb68489ba4aac87d0f6c5785
Requested by: @CarinaWolli

@graphite-app graphite-app bot added the core area: core, team members only label Feb 9, 2026
@graphite-app graphite-app bot requested a review from a team February 9, 2026 16:31
@graphite-app graphite-app bot added the consumer label Feb 9, 2026
Copy link
Copy Markdown
Member

@dhairyashiil dhairyashiil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested locally

@dhairyashiil dhairyashiil enabled auto-merge (squash) February 9, 2026 18:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 9, 2026

E2E results are ready!

@dhairyashiil dhairyashiil merged commit b03c00a into main Feb 10, 2026
127 of 130 checks passed
@dhairyashiil dhairyashiil deleted the devin/1770654566-fix-team-name-duplicate-label branch February 10, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only ready-for-e2e size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants