Skip to content

refactor: remove 3 @calcom/web imports from @calcom/features by relocating blocklist UI and useEvent hook#27775

Merged
hbjORbj merged 6 commits intomainfrom
refactor/move-3-files-from-trpc-to-web
Feb 9, 2026
Merged

refactor: remove 3 @calcom/web imports from @calcom/features by relocating blocklist UI and useEvent hook#27775
hbjORbj merged 6 commits intomainfrom
refactor/move-3-files-from-trpc-to-web

Conversation

@hbjORbj
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj commented Feb 9, 2026

What does this PR do?

Removes 3 @calcom/web imports from @calcom/features by moving the blocklist UI components and useEvent/useScheduleForEvent hooks into apps/web/modules/, and removes 4 dead type imports from packages/features/bookings/Booker/types.ts.

Why this matters

  • Fixes a silently broken import: useEvent in packages/features imported useSchedule via "~/schedules/hooks/useSchedule" — which only resolved because apps/web's tsconfig maps ~ to modules/*. Under packages/features' own tsconfig (~./*), the file doesn't exist. The typecheck CI never caught this because packages/features has no type-check script; it's only checked transitively through apps/web's tsc, which applies the wrong path alias.
  • Enforces package boundaries: useEvent depends on @calcom/trpc/react, which belongs in apps/web/modules/, not packages/features. The blocklist components similarly depend on web-only imports (~/data-table/components).
  • Removes dead code: 4 unused type imports removed from packages/features/bookings/Booker/types.ts (including a @calcom/trpc import).

No runtime behavior change.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A — no docs changes needed.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Build verification only — no functional changes. Confirm the app builds and the affected views (blocklist admin, org privacy/blocklist, booker, embed) render correctly.

@paragon-review
Copy link
Copy Markdown

paragon-review bot commented Feb 9, 2026

Paragon Review Unavailable

Hi @hbjORbj! You are not toggled active by your team. Reach out to your admin.

@graphite-app graphite-app bot added foundation core area: core, team members only labels Feb 9, 2026
@graphite-app graphite-app bot requested a review from a team February 9, 2026 06:05
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 20 files

@calcom-bot calcom-bot changed the title refactor: Remove 3 @calcom/web imports in @calcom/features refactor: remove 3 @calcom/web imports from @calcom/features by relocating blocklist UI and useEvent hook Feb 9, 2026
@hbjORbj hbjORbj enabled auto-merge (squash) February 9, 2026 06:22
@hbjORbj hbjORbj requested a review from a team as a code owner February 9, 2026 06:38
@hbjORbj hbjORbj force-pushed the refactor/move-3-files-from-trpc-to-web branch from eb5d419 to 7fd0e44 Compare February 9, 2026 06:39
@hbjORbj hbjORbj merged commit 29bb4fd into main Feb 9, 2026
121 of 126 checks passed
@hbjORbj hbjORbj deleted the refactor/move-3-files-from-trpc-to-web branch February 9, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants