fix: use LOGO_DARK constant for generic OG image instead of hardcoded value#27705
Merged
fix: use LOGO_DARK constant for generic OG image instead of hardcoded value#27705
Conversation
|
Paragon Review Unavailable Hi @hbjORbj! You are not toggled active by your team. Reach out to your admin. |
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: [email protected] <[email protected]>
…logo' into devin/1770380961-fix-generic-og-logo
devin-ai-integration
bot
changed the title
eunjae-lee
reviewed
Feb 6, 2026
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
eunjae-lee
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Self-hosted Cal.com instances display the default Cal.com logo on OG images for "generic" type pages (login, etc.) because the
genericentry inOG_ASSETShardcoded"cal-logo-word-black.svg"as a raw string instead of referencing a constant.This PR:
LOGO_DARKconstant inpackages/lib/constants.tspointing to/cal-logo-word-black.svg— preserving the darker logo for generic OG images on light backgrounds.genericinOG_ASSETSto useLOGO_DARK ?? LOGOinstead of the hardcoded string, so the file reference is a discoverable, replaceable constant.OgImagesmodule coveringgetOGImageVersion,constructMeetingImage,constructAppImage,constructGenericImage, and branding consistency.Logo strategy per OG type:
LOGOcalcom-logo-white-word.svgLOGOcalcom-logo-white-word.svgLOGO_DARK ?? LOGOcal-logo-word-black.svgSelf-hosters who want full branding consistency should replace both
calcom-logo-white-word.svgandcal-logo-word-black.svg.Visual Demo
To demonstrate the fix,
cal-logo-word-black.svg(the file referenced byLOGO_DARK) was replaced with a custom logo to simulate a self-hosted instance.Default generic OG image (no custom logo):
After replacing
cal-logo-word-black.svgwith custom logo — generic OG picks up the change:Meeting OG remains unaffected (uses
LOGO, notLOGO_DARK):Mandatory Tasks (DO NOT REMOVE)