fix: allow unmarking host as no-show#27694
Merged
Udit-takkar merged 6 commits intomainfrom Feb 9, 2026
Merged
Conversation
…updateAttendees Co-Authored-By: [email protected] <[email protected]>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…y pattern Co-Authored-By: [email protected] <[email protected]>
Udit-takkar
approved these changes
Feb 6, 2026
Contributor
E2E results are ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug in
handleMarkNoShow.tswhere a host cannot be unmarked as no-show once marked.When
noShowHost: falseis passed to undo a mistaken no-show marking, theif (noShowHost)condition evaluates tofalseand skips the update entirely. Additionally, the database update and response payload both hardcodetrueinstead of using the actual value.Changes:
if (noShowHost)→if (noShowHost !== undefined)to allowfalsevalues throughnoShowHost: true→noShowHost(actual value) inbookingRepository.updateNoShowHostresponsePayload.setNoShowHost(true)→responsePayload.setNoShowHost(noShowHost)Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
noShowHostis set totruein the databasenoShowHost: false) → verifynoShowHostis set tofalsein the database and the response reflects the changeHuman Review Checklist
noShowHosttype fromTNoShowInputSchema— confirmundefinedis the correct "not provided" sentinel (vsnull)bookingRepository.updateNoShowHosthandlesnoShowHost: falsecorrectly (persistsfalseto the DB, doesn't skip or error)Link to Devin run
https://app.devin.ai/sessions/ef7c51021f4f402ab68a3bc592aa0f04
Requested by
@hariombalhara