Skip to content

fix: allow unmarking host as no-show#27694

Merged
Udit-takkar merged 6 commits intomainfrom
devin/1770370712-fix-unmark-host-noshow
Feb 9, 2026
Merged

fix: allow unmarking host as no-show#27694
Udit-takkar merged 6 commits intomainfrom
devin/1770370712-fix-unmark-host-noshow

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Feb 6, 2026

What does this PR do?

Fixes a bug in handleMarkNoShow.ts where a host cannot be unmarked as no-show once marked.

When noShowHost: false is passed to undo a mistaken no-show marking, the if (noShowHost) condition evaluates to false and skips the update entirely. Additionally, the database update and response payload both hardcode true instead of using the actual value.

Changes:

  • Changed if (noShowHost)if (noShowHost !== undefined) to allow false values through
  • Changed hardcoded noShowHost: truenoShowHost (actual value) in bookingRepository.updateNoShowHost
  • Changed hardcoded responsePayload.setNoShowHost(true)responsePayload.setNoShowHost(noShowHost)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A — no docs changes needed.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Mark a host as no-show via the webapp → verify noShowHost is set to true in the database
  2. Unmark the host (set noShowHost: false) → verify noShowHost is set to false in the database and the response reflects the change

Human Review Checklist

  • Verify noShowHost type from TNoShowInputSchema — confirm undefined is the correct "not provided" sentinel (vs null)
  • Verify bookingRepository.updateNoShowHost handles noShowHost: false correctly (persists false to the DB, doesn't skip or error)
  • Confirm no tests exist for the unmark host flow; consider whether tests should be added

Link to Devin run

https://app.devin.ai/sessions/ef7c51021f4f402ab68a3bc592aa0f04

Requested by

@hariombalhara

@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@pull-request-size pull-request-size bot added size/XS and removed size/S labels Feb 6, 2026
@devin-ai-integration devin-ai-integration bot changed the title fix: allow unmarking host as no-show and filter invalid attendees in updateAttendees fix: allow unmarking host as no-show Feb 6, 2026
@hariombalhara hariombalhara self-assigned this Feb 6, 2026
@hariombalhara hariombalhara added this to the v6.2 milestone Feb 6, 2026
@hariombalhara hariombalhara marked this pull request as ready for review February 6, 2026 09:50
@graphite-app graphite-app bot requested a review from a team February 6, 2026 09:50
@graphite-app graphite-app bot added enterprise area: enterprise, audit log, organisation, SAML, SSO core area: core, team members only labels Feb 6, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@Udit-takkar Udit-takkar enabled auto-merge (squash) February 6, 2026 16:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2026

E2E results are ready!

@Udit-takkar Udit-takkar merged commit 0a2d085 into main Feb 9, 2026
50 of 51 checks passed
@Udit-takkar Udit-takkar deleted the devin/1770370712-fix-unmark-host-noshow branch February 9, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants